extensions/common/api/app_window.idl - Issue 2209053004: Enhance chrome.app.window API with icon property

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/api/app_window.idl

Issue 2209053004: Enhance chrome.app.window API with icon property (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review v2 + Badge Icon Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/common/api/app_window.idl

diff --git a/extensions/common/api/app_window.idl b/extensions/common/api/app_window.idl

index 07ac8fca01ab31566b55eb4082692ecb90e1cd19..331f0487ba3e6c05025af52938583485a4eff022 100644

--- a/extensions/common/api/app_window.idl

+++ b/extensions/common/api/app_window.idl

@@ -231,6 +231,10 @@ namespace app.window {

// specify an id for the window.

boolean? showInShelf;

+ // URL of the window icon. A window can have its own icon when showInShelf

+ // is set to true.

stevenjb 2016/08/08 22:26:46 We should document what types of urls are valid he

Andra Paraschiv 2016/08/09 11:34:47 Done.

+ DOMString? icon;

// Frame type: <code>none</code> or <code>chrome</code> (defaults to

// <code>chrome</code>). For <code>none</code>, the

// <code>-webkit-app-region</code> CSS property can be used to apply