Enhance chrome.app.window API with icon property

extensions/browser/api/app_window/app_window_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/browser/api/app_window/app_window_api.h"
 
 #include <memory>
 #include <utility>
 
 #include "base/command_line.h"
@@ skipping 314 matching lines @@
 
     if (options->show_in_shelf.get()) {
       create_params.show_in_shelf = *options->show_in_shelf.get();
 
       if (create_params.show_in_shelf && create_params.window_key.empty()) {
         error_ = app_window_constants::kShowInShelfWindowKeyNotSet;
         return false;
       }
     }
 
+    if (options->icon.get()) {
+      create_params.window_icon_url = GURL(*options->icon.get());
+

[stevenjb, 2016/08/08 22:26:45]

If I read this correctly, first we are looking for a valid global URL, then a
valid extension local URL? We should add a comment here.

[Andra Paraschiv, 2016/08/09 11:34:47]

Done.

+      if (!create_params.window_icon_url.is_valid()) {
+        create_params.window_icon_url =
+            extension()->GetResourceURL(*options->icon.get());
+      }
+    }
+
     if (options->type != app_window::WINDOW_TYPE_PANEL) {
       switch (options->state) {
         case app_window::STATE_NONE:
         case app_window::STATE_NORMAL:
           break;
         case app_window::STATE_FULLSCREEN:
           create_params.state = ui::SHOW_STATE_FULLSCREEN;
           break;
         case app_window::STATE_MAXIMIZED:
           create_params.state = ui::SHOW_STATE_MAXIMIZED;
@@ skipping 219 matching lines @@
 
   if (options.frame->as_frame_options->inactive_color.get()) {
     error_ = app_window_constants::kInactiveColorWithoutColor;
     return false;
   }
 
   return true;
 }
 
 }  // namespace extensions