Issue 2209053002: Add a presubmit check for element.$.localId

Issue 2209053002: Add a presubmit check for element.$.localId (Closed)

Created:
4 years, 4 months ago by Dan Beam

Modified:
4 years, 4 months ago

Reviewers:
tsergeant

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Add a presubmit check for element.$.localId R=tsergeant@chromium.org BUG=none Committed: https://crrev.com/a082f45811fe0e3452e7fdf74b67a1f19e828fa1 Cr-Commit-Position: refs/heads/master@{#409719}

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -0 lines)			Patch
	M	chrome/browser/web_dev_style/js_checker.py	View	1	2 chunks	+6 lines, -0 lines	0 comments	Download
	M	chrome/browser/web_dev_style/js_checker_test.py	View		1 chunk	+32 lines, -0 lines	0 comments	Download

Total messages: 9 (4 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2209053002/20001

4 years, 4 months ago (2016-08-04 04:13:05 UTC) #6

commit-bot: I haz the power

4 years, 4 months ago (2016-08-04 04:43:04 UTC) #9

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/a082f45811fe0e3452e7fdf74b67a1f19e828fa1
Cr-Commit-Position: refs/heads/master@{#409719}