Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(763)

Unified Diff: Source/devtools/front_end/ObjectPropertiesSection.js

Issue 220903002: DevTools: wrap DebuggerAgent.Location with DebuggerModel.Location. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: All tests!!! Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/ObjectPropertiesSection.js
diff --git a/Source/devtools/front_end/ObjectPropertiesSection.js b/Source/devtools/front_end/ObjectPropertiesSection.js
index fef5a8bde733595981d6043c1e5f585750d3f294..c4e6404633e9a318fce170f0944f3792ce728151 100644
--- a/Source/devtools/front_end/ObjectPropertiesSection.js
+++ b/Source/devtools/front_end/ObjectPropertiesSection.js
@@ -604,16 +604,13 @@ WebInspector.FunctionScopeMainTreeElement.prototype = {
return;
/**
- * @param {?Protocol.Error} error
- * @param {!DebuggerAgent.FunctionDetails} response
+ * @param {?DebuggerAgent.FunctionDetails} response
* @this {WebInspector.FunctionScopeMainTreeElement}
*/
- function didGetDetails(error, response)
+ function didGetDetails(response)
{
- if (error) {
- console.error(error);
+ if (!response)
return;
- }
this.removeChildren();
var scopeChain = response.scopeChain;
@@ -665,7 +662,7 @@ WebInspector.FunctionScopeMainTreeElement.prototype = {
}
}
- DebuggerAgent.getFunctionDetails(this._remoteObject.objectId, didGetDetails.bind(this));
+ this._remoteObject.functionDetails(didGetDetails.bind(this));
},
__proto__: TreeElement.prototype
« no previous file with comments | « Source/devtools/front_end/ObjectPopoverHelper.js ('k') | Source/devtools/front_end/PresentationConsoleMessageHelper.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698