Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Unified Diff: Source/devtools/front_end/ConsoleView.js

Issue 220903002: DevTools: wrap DebuggerAgent.Location with DebuggerModel.Location. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: All tests!!! Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/devtools/front_end/ConsoleModel.js ('k') | Source/devtools/front_end/ConsoleViewMessage.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/ConsoleView.js
diff --git a/Source/devtools/front_end/ConsoleView.js b/Source/devtools/front_end/ConsoleView.js
index a3cf9e8ec6a76e2d5b179078e7a66edac6364f52..deb178cff675b1b9f4dbdd2757a5664509b4660f 100644
--- a/Source/devtools/front_end/ConsoleView.js
+++ b/Source/devtools/front_end/ConsoleView.js
@@ -756,17 +756,15 @@ WebInspector.ConsoleView.prototype = {
return;
}
- target.debuggerAgent().getFunctionDetails(result.objectId, didGetDetails.bind(this));
+ result.functionDetails(didGetDetails.bind(this));
/**
- * @param {?Protocol.Error} error
- * @param {!DebuggerAgent.FunctionDetails} response
+ * @param {?DebuggerAgent.FunctionDetails} response
* @this {WebInspector.ConsoleView}
*/
- function didGetDetails(error, response)
+ function didGetDetails(response)
{
- if (error) {
- console.error(error);
+ if (!response) {
addMessage.call(this);
return;
}
@@ -774,12 +772,13 @@ WebInspector.ConsoleView.prototype = {
var url;
var lineNumber;
var columnNumber;
- var script = WebInspector.debuggerModel.scriptForId(response.location.scriptId);
+ var script = target.debuggerModel.scriptForId(response.location.scriptId);
if (script && script.sourceURL) {
url = script.sourceURL;
lineNumber = response.location.lineNumber + 1;
columnNumber = response.location.columnNumber + 1;
}
+ // FIXME: this should be using live location.
addMessage.call(this, url, lineNumber, columnNumber);
}
},
« no previous file with comments | « Source/devtools/front_end/ConsoleModel.js ('k') | Source/devtools/front_end/ConsoleViewMessage.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698