DevTools: wrap DebuggerAgent.Location with DebuggerModel.Location.

Source/devtools/front_end/EventListenersSidebarPane.js

 /*
  * Copyright (C) 2007 Apple Inc.  All rights reserved.
  * Copyright (C) 2009 Joseph Pecoraro
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
@@ skipping 69 matching lines @@
     {
         RuntimeAgent.releaseObjectGroup(WebInspector.EventListenersSidebarPane._objectGroupName);
         this._linkifier.reset();
 
         var body = this.bodyElement;
         body.removeChildren();
         this.sections = [];
 
         var self = this;
         /**
-         * @param {?Protocol.Error} error
-         * @param {!Array.<!DOMAgent.EventListener>} eventListeners
+         * @param {?Array.<!WebInspector.DOMModel.EventListener>} eventListeners
          */
-        function callback(error, eventListeners)
+        function callback(eventListeners)
         {
-            if (error)
+            if (!eventListeners)
                 return;
 
             var selectedNodeOnly = "selected" === WebInspector.settings.eventListenersFilter.get();
             var sectionNames = [];
             var sectionMap = {};
             for (var i = 0; i < eventListeners.length; ++i) {
                 var eventListener = eventListeners[i];
-                if (selectedNodeOnly && (node.id !== eventListener.nodeId))
+                if (selectedNodeOnly && (node.id !== eventListener.payload().nodeId))
                     continue;
-                eventListener.node = node.target().domModel.nodeForId(eventListener.nodeId);
-                delete eventListener.nodeId; // no longer needed
-                if (/^function _inspectorCommandLineAPI_logEvent\(/.test(eventListener.handlerBody.toString()))
+                if (/^function _inspectorCommandLineAPI_logEvent\(/.test(eventListener.payload().handlerBody.toString()))
                     continue; // ignore event listeners generated by monitorEvent
-                var type = eventListener.type;
+                var type = eventListener.payload().type;
                 var section = sectionMap[type];
                 if (!section) {
                     section = new WebInspector.EventListenersSection(type, node.id, self._linkifier);
                     sectionMap[type] = section;
                     sectionNames.push(type);
                     self.sections.push(section);
                 }
-                section.addListener(node.target(), eventListener);
+                section.addListener(eventListener);
             }
 
             if (sectionNames.length === 0) {
                 var div = document.createElement("div");
                 div.className = "info";
                 div.textContent = WebInspector.UIString("No Event Listeners");
                 body.appendChild(div);
                 return;
             }
 
@@ skipping 47 matching lines @@
     delete this.propertiesElement;
     delete this.propertiesTreeOutline;
 
     this._eventBars = document.createElement("div");
     this._eventBars.className = "event-bars";
     this.element.appendChild(this._eventBars);
 }
 
 WebInspector.EventListenersSection.prototype = {
     /**
-     * @param {!WebInspector.Target} target
+     * @param {!WebInspector.DOMModel.EventListener} eventListener
      */
-    addListener: function(target, eventListener)
+    addListener: function(eventListener)
     {
-        var eventListenerBar = new WebInspector.EventListenerBar(target, eventListener, this._nodeId, this._linkifier);
+        var eventListenerBar = new WebInspector.EventListenerBar(eventListener, this._nodeId, this._linkifier);
         this._eventBars.appendChild(eventListenerBar.element);
     },
 
     __proto__: WebInspector.PropertiesSection.prototype
 }
 
 /**
  * @constructor
- * @param {!WebInspector.Target} target
  * @extends {WebInspector.ObjectPropertiesSection}
+ * @param {!WebInspector.DOMModel.EventListener} eventListener
+ * @param {!DOMAgent.NodeId} nodeId
+ * @param {!WebInspector.Linkifier} linkifier
  */
-WebInspector.EventListenerBar = function(target, eventListener, nodeId, linkifier)
+WebInspector.EventListenerBar = function(eventListener, nodeId, linkifier)
 {
+    var target = eventListener.target();
     WebInspector.ObjectPropertiesSection.call(this, target.runtimeModel.createRemoteObjectFromPrimitiveValue(""));
 
     this._runtimeModel = target.runtimeModel;
-    this.eventListener = eventListener;
+    this._eventListener = eventListener;
     this._nodeId = nodeId;
     this._setNodeTitle();
     this._setFunctionSubtitle(linkifier);
     this.editable = false;
     this.element.className = "event-bar"; /* Changed from "section" */
     this.headerElement.classList.add("source-code");
     this.propertiesElement.className = "event-properties properties-tree source-code"; /* Changed from "properties" */
 }
 
 WebInspector.EventListenerBar.prototype = {
     update: function()
     {
         /**
          * @param {?WebInspector.RemoteObject} nodeObject
          * @this {WebInspector.EventListenerBar}
          */
         function updateWithNodeObject(nodeObject)
         {
             var properties = [];
+            var payload = this._eventListener.payload();
 
-            properties.push(this._runtimeModel.createRemotePropertyFromPrimitiveValue("type", this.eventListener.type));
-            properties.push(this._runtimeModel.createRemotePropertyFromPrimitiveValue("useCapture", this.eventListener.useCapture));
-            properties.push(this._runtimeModel.createRemotePropertyFromPrimitiveValue("isAttribute", this.eventListener.isAttribute));
+            properties.push(this._runtimeModel.createRemotePropertyFromPrimitiveValue("type", payload.type));
+            properties.push(this._runtimeModel.createRemotePropertyFromPrimitiveValue("useCapture", payload.useCapture));
+            properties.push(this._runtimeModel.createRemotePropertyFromPrimitiveValue("isAttribute", payload.isAttribute));
             if (nodeObject)
                 properties.push(new WebInspector.RemoteObjectProperty("node", nodeObject));
-            if (typeof this.eventListener.handler !== "undefined") {
-                var remoteObject = this._runtimeModel.createRemoteObject(this.eventListener.handler);
+            if (typeof payload.handler !== "undefined") {
+                var remoteObject = this._runtimeModel.createRemoteObject(payload.handler);
                 properties.push(new WebInspector.RemoteObjectProperty("handler", remoteObject));
             }
-            properties.push(this._runtimeModel.createRemotePropertyFromPrimitiveValue("listenerBody", this.eventListener.handlerBody));
-            if (this.eventListener.sourceName)
-                properties.push(this._runtimeModel.createRemotePropertyFromPrimitiveValue("sourceName", this.eventListener.sourceName));
-            properties.push(this._runtimeModel.createRemotePropertyFromPrimitiveValue("lineNumber", this.eventListener.location.lineNumber + 1));
+            properties.push(this._runtimeModel.createRemotePropertyFromPrimitiveValue("listenerBody", payload.handlerBody));
+            if (payload.sourceName)
+                properties.push(this._runtimeModel.createRemotePropertyFromPrimitiveValue("sourceName", payload.sourceName));
+            properties.push(this._runtimeModel.createRemotePropertyFromPrimitiveValue("lineNumber", payload.location.lineNumber + 1));
 
             this.updateProperties(properties);
         }
-        this.eventListener.node.resolveToObject(WebInspector.EventListenersSidebarPane._objectGroupName, updateWithNodeObject.bind(this));
+        this._eventListener.node().resolveToObject(WebInspector.EventListenersSidebarPane._objectGroupName, updateWithNodeObject.bind(this));
     },
 
     _setNodeTitle: function()
     {
-        var node = this.eventListener.node;
+        var node = this._eventListener.node();
         if (!node)
             return;
 
         if (node.nodeType() === Node.DOCUMENT_NODE) {
             this.titleElement.textContent = "document";
             return;
         }
 
         if (node.id === this._nodeId) {
             this.titleElement.textContent = WebInspector.DOMPresentationUtils.simpleSelector(node);
             return;
         }
 
         this.titleElement.removeChildren();
-        this.titleElement.appendChild(WebInspector.DOMPresentationUtils.linkifyNodeReference(this.eventListener.node));
+        this.titleElement.appendChild(WebInspector.DOMPresentationUtils.linkifyNodeReference(node));
     },
 
     _setFunctionSubtitle: function(linkifier)
     {
         this.subtitleElement.removeChildren();
-        var urlElement = linkifier.linkifyRawLocation(this.eventListener.location);
-        if (!urlElement) {
-            var url = this.eventListener.sourceName;
-            var lineNumber = this.eventListener.location.lineNumber;
-            var columnNumber = 0;
-            urlElement = linkifier.linkifyLocation(url, lineNumber, columnNumber);
-        }
-        this.subtitleElement.appendChild(urlElement);
+        this.subtitleElement.appendChild(linkifier.linkifyRawLocation(this._eventListener.location()));
     },
 
     __proto__: WebInspector.ObjectPropertiesSection.prototype
 }