Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 220903002: DevTools: wrap DebuggerAgent.Location with DebuggerModel.Location. (Closed)

Created:
6 years, 8 months ago by pfeldman
Modified:
6 years, 8 months ago
Reviewers:
apavlov, sergeyv
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

DevTools: wrap DebuggerAgent.Location with DebuggerModel.Location. R=sergeyv@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170579

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Fixed some tests. #

Patch Set 4 : More test fixes. #

Patch Set 5 : All tests!!! #

Unified diffs Side-by-side diffs Delta from patch set Stats (+467 lines, -269 lines) Patch
M LayoutTests/http/tests/inspector/debugger-test.js View 1 2 3 4 5 chunks +10 lines, -10 lines 0 comments Download
M LayoutTests/http/tests/inspector/elements/styles/update-locations-on-filesystem-scss-load.html View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/inspector/inspector-test.js View 1 2 1 chunk +2 lines, -5 lines 0 comments Download
M LayoutTests/http/tests/inspector/stylesheet-source-mapping.html View 1 2 3 chunks +3 lines, -2 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/async-callstack-eval.html View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/async-callstack-middle-run.html View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/async-callstack-mutation-observer-expected.txt View 1 2 3 6 chunks +0 lines, -10 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/async-callstack-promises-expected.txt View 1 2 3 1 chunk +2 lines, -3 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/async-callstack-scopes.html View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/breakpoint-manager.html View 1 2 12 chunks +19 lines, -12 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/debug-inlined-scripts.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/sources/debugger/debug-inlined-scripts-expected.txt View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/debugger-no-pause-on-antibreakpoint.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/sources/debugger/debugger-no-pause-on-antibreakpoint-expected.txt View 1 2 3 1 chunk +1 line, -3 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/debugger-pause-in-internal-expected.txt View 1 2 3 1 chunk +2 lines, -3 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/debugger-return-value.html View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/sources/debugger/pause-in-inline-script.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/sources/debugger/pause-in-internal-script-expected.txt View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/properties-special.html View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/reveal-execution-line.html View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/skip-stack-frames-steps.html View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/watch-expressions-panel-switch.html View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/BreakpointManager.js View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/CPUProfileView.js View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/devtools/front_end/CPUProfilerModel.js View 1 2 5 chunks +10 lines, -7 lines 0 comments Download
M Source/devtools/front_end/CSSStyleModel.js View 1 2 6 chunks +30 lines, -7 lines 0 comments Download
M Source/devtools/front_end/ConsoleModel.js View 1 2 3 chunks +5 lines, -4 lines 0 comments Download
M Source/devtools/front_end/ConsoleView.js View 2 chunks +6 lines, -7 lines 0 comments Download
M Source/devtools/front_end/ConsoleViewMessage.js View 1 2 7 chunks +12 lines, -9 lines 0 comments Download
M Source/devtools/front_end/DOMModel.js View 1 2 5 chunks +71 lines, -6 lines 0 comments Download
M Source/devtools/front_end/DebuggerModel.js View 1 2 20 chunks +121 lines, -47 lines 0 comments Download
M Source/devtools/front_end/DefaultScriptMapping.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/EventListenersSidebarPane.js View 1 2 7 chunks +30 lines, -36 lines 0 comments Download
M Source/devtools/front_end/JavaScriptSourceFrame.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/Linkifier.js View 1 2 2 chunks +4 lines, -3 lines 0 comments Download
M Source/devtools/front_end/LiveEditSupport.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/Main.js View 1 2 2 chunks +8 lines, -12 lines 0 comments Download
M Source/devtools/front_end/ObjectPopoverHelper.js View 3 chunks +7 lines, -8 lines 0 comments Download
M Source/devtools/front_end/ObjectPropertiesSection.js View 2 chunks +4 lines, -7 lines 0 comments Download
M Source/devtools/front_end/PresentationConsoleMessageHelper.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/ProfileDataGridTree.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/RemoteObject.js View 1 2 2 chunks +19 lines, -3 lines 0 comments Download
M Source/devtools/front_end/ResourceScriptMapping.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/RuntimeModel.js View 1 2 10 chunks +14 lines, -13 lines 0 comments Download
M Source/devtools/front_end/SASSSourceMapping.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/Script.js View 4 chunks +6 lines, -4 lines 0 comments Download
M Source/devtools/front_end/ScriptFormatterEditorAction.js View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M Source/devtools/front_end/SourcesPanel.js View 2 chunks +4 lines, -1 line 0 comments Download
M Source/devtools/front_end/StylesSidebarPane.js View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M Source/devtools/front_end/StylesSourceMapping.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/Target.js View 1 chunk +23 lines, -0 lines 0 comments Download
M Source/devtools/front_end/UISourceCode.js View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
pfeldman
6 years, 8 months ago (2014-04-01 13:32:07 UTC) #1
sergeyv
lgtm
6 years, 8 months ago (2014-04-01 14:34:58 UTC) #2
pfeldman
The CQ bit was checked by pfeldman@chromium.org
6 years, 8 months ago (2014-04-01 14:35:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pfeldman@chromium.org/220903002/80001
6 years, 8 months ago (2014-04-01 14:35:24 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-01 15:22:21 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 8 months ago (2014-04-01 15:22:22 UTC) #6
pfeldman
6 years, 8 months ago (2014-04-01 16:05:39 UTC) #7
Message was sent while issue was closed. 
Committed patchset #5 manually as r170579 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698