Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1223)

Issue 2209003002: Remove the swizzling of -[NSEvent window] and the middle button in EventsMacTest (Closed)

Created:
4 years, 4 months ago by tapted
Modified:
4 years, 4 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, tdresser+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the swizzling of -[NSEvent window] and the middle button in EventsMacTest The NSEvent initializers for creating test events are limited, so we currently swizzle some properties. In a follow-up, we also want test events that include phase information for scrolling. The swizzling for that was becoming complex, but we can replace the swizzling by making more use of CGEventSetIntegerValueField(..) and adding a tiny bit of reflection. BUG=615948 TEST=events_unittests still passing Committed: https://crrev.com/033117f328bb004ae5f466351734f175d07ab5c7 Cr-Commit-Position: refs/heads/master@{#409718}

Patch Set 1 #

Patch Set 2 : more private #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -81 lines) Patch
M ui/events/cocoa/events_mac_unittest.mm View 1 10 chunks +48 lines, -81 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
tapted
Hi avi, please take a look
4 years, 4 months ago (2016-08-04 01:41:51 UTC) #8
Avi (use Gerrit)
lgtm If it works, ship it!
4 years, 4 months ago (2016-08-04 04:25:33 UTC) #9
tapted
4 years, 4 months ago (2016-08-04 04:31:41 UTC) #10
tapted
thanks!
4 years, 4 months ago (2016-08-04 04:32:11 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2209003002/40001
4 years, 4 months ago (2016-08-04 04:32:42 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 4 months ago (2016-08-04 04:35:58 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-08-04 04:37:56 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/033117f328bb004ae5f466351734f175d07ab5c7
Cr-Commit-Position: refs/heads/master@{#409718}

Powered by Google App Engine
This is Rietveld 408576698