Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 2208983002: Support multiple lines for status text on Chooser UI on Mac (Closed)

Created:
4 years, 4 months ago by juncai
Modified:
4 years, 4 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Support multiple lines for status text on Chooser UI on Mac This CL updated code to support multiple lines for status text on Mac. This fixed the issue when the translated status text is too long to be displayed in one line. BUG=630955 Committed: https://crrev.com/20dcd15ebc1fbc8f39642cf4f688656369d769fb Cr-Commit-Position: refs/heads/master@{#410422}

Patch Set 1 : support multiple lines for status text on Chooser UI on Mac #

Patch Set 2 : clean up code #

Total comments: 2

Patch Set 3 : added TODO #

Patch Set 4 : added TODO #

Unified diffs Side-by-side diffs Delta from patch set Stats (+171 lines, -39 lines) Patch
M chrome/browser/ui/cocoa/chooser_content_view_cocoa.h View 1 2 chunks +46 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/chooser_content_view_cocoa.mm View 1 2 15 chunks +125 lines, -39 lines 0 comments Download

Messages

Total messages: 22 (16 generated)
juncai
Please take a look.
4 years, 4 months ago (2016-08-04 00:45:36 UTC) #4
Robert Sesek
LGTM https://codereview.chromium.org/2208983002/diff/20001/chrome/browser/ui/cocoa/chooser_content_view_cocoa.mm File chrome/browser/ui/cocoa/chooser_content_view_cocoa.mm (right): https://codereview.chromium.org/2208983002/diff/20001/chrome/browser/ui/cocoa/chooser_content_view_cocoa.mm#newcode178 chrome/browser/ui/cocoa/chooser_content_view_cocoa.mm:178: - (instancetype)initWithChooserTitle:(NSString*)chooserTitle For follow-up CL, I'd maybe restructure ...
4 years, 4 months ago (2016-08-08 18:53:04 UTC) #11
juncai
https://codereview.chromium.org/2208983002/diff/20001/chrome/browser/ui/cocoa/chooser_content_view_cocoa.mm File chrome/browser/ui/cocoa/chooser_content_view_cocoa.mm (right): https://codereview.chromium.org/2208983002/diff/20001/chrome/browser/ui/cocoa/chooser_content_view_cocoa.mm#newcode178 chrome/browser/ui/cocoa/chooser_content_view_cocoa.mm:178: - (instancetype)initWithChooserTitle:(NSString*)chooserTitle On 2016/08/08 18:53:03, Robert Sesek wrote: > ...
4 years, 4 months ago (2016-08-08 19:17:39 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2208983002/60001
4 years, 4 months ago (2016-08-08 20:08:10 UTC) #19
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 4 months ago (2016-08-08 20:15:59 UTC) #20
commit-bot: I haz the power
4 years, 4 months ago (2016-08-08 20:18:53 UTC) #22
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/20dcd15ebc1fbc8f39642cf4f688656369d769fb
Cr-Commit-Position: refs/heads/master@{#410422}

Powered by Google App Engine
This is Rietveld 408576698