chrome/browser/ui/views/bookmarks/bookmark_bar_instructions_view.cc - Issue 2208973003: Add some extra height to bookmark bar if the font wants to be larger

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/bookmarks/bookmark_bar_instructions_view.cc

Issue 2208973003: Add some extra height to bookmark bar if the font wants to be larger (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address various nits from code review comments Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller_unittest.mm ('k') | chrome/browser/ui/views/bookmarks/bookmark_bar_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/bookmarks/bookmark_bar_instructions_view.cc

diff --git a/chrome/browser/ui/views/bookmarks/bookmark_bar_instructions_view.cc b/chrome/browser/ui/views/bookmarks/bookmark_bar_instructions_view.cc

index 7064073e301089b5ffdb55112ecfb706b36a5820..71884cfad0e8799e8ca553e076ca62caa3259584 100644

--- a/chrome/browser/ui/views/bookmarks/bookmark_bar_instructions_view.cc

+++ b/chrome/browser/ui/views/bookmarks/bookmark_bar_instructions_view.cc

@@ -69,7 +69,8 @@ gfx::Size BookmarkBarInstructionsView::GetPreferredSize() const {

width += pref.width();

}

width += (child_count() - 1) * GetViewPadding();

- return gfx::Size(width, height);

+ gfx::Insets insets = GetInsets();

+ return gfx::Size(width + insets.width(), height + insets.height());

}

void BookmarkBarInstructionsView::Layout() {