chrome/browser/ui/views/frame/browser_view.cc - Issue 2208973003: Add some extra height to bookmark bar if the font wants to be larger

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/frame/browser_view.cc

Issue 2208973003: Add some extra height to bookmark bar if the font wants to be larger (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Call GetPreferredHeight() only once in GetPreferredSize() Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc ('K') | « chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc ('k') | chrome/browser/ui/webui/ntp/ntp_resource_cache.cc » ('j') | chrome/browser/ui/webui/ntp/ntp_resource_cache.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/frame/browser_view.cc

diff --git a/chrome/browser/ui/views/frame/browser_view.cc b/chrome/browser/ui/views/frame/browser_view.cc

index e0896b097faf8f623e0ab52116a4fa38167c3103..63ba37d407ae3b3f7ffe94dba9fa8425962bdb3c 100644

--- a/chrome/browser/ui/views/frame/browser_view.cc

+++ b/chrome/browser/ui/views/frame/browser_view.cc

@@ -2524,8 +2524,8 @@ int BrowserView::GetRenderViewHeightInsetWithDetachedBookmarkBar() {

}

// Don't use bookmark_bar_view_->height() which won't be the final height if

// the bookmark bar is animating.

- return chrome::kNTPBookmarkBarHeight -

- views::NonClientFrameView::kClientEdgeThickness;

+ return chrome::kNTPMinimumBookmarkBarHeight -

+ views::NonClientFrameView::kClientEdgeThickness;

}

void BrowserView::ExecuteExtensionCommand(