Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(607)

Unified Diff: chrome/browser/ui/bookmarks/bookmark_bar_constants.h

Issue 2208973003: Add some extra height to bookmark bar if the font wants to be larger (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Call GetPreferredHeight() only once in GetPreferredSize() Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/bookmarks/bookmark_bar_constants.h
diff --git a/chrome/browser/ui/bookmarks/bookmark_bar_constants.h b/chrome/browser/ui/bookmarks/bookmark_bar_constants.h
index a6c4e7bae77b9e820bbd8345200c859ae8de9c34..8ef99192adc2044c16644047ea10da644367094a 100644
--- a/chrome/browser/ui/bookmarks/bookmark_bar_constants.h
+++ b/chrome/browser/ui/bookmarks/bookmark_bar_constants.h
@@ -11,7 +11,7 @@ namespace chrome {
// The height of Bookmarks Bar, when visible in "New Tab Page" mode.
#if defined(TOOLKIT_VIEWS) || defined(OS_MACOSX)
sky 2016/08/16 21:56:13 This leaves ios and android out, which I don't bel
kylix_rd 2016/08/17 15:39:02 Done.
-const int kNTPBookmarkBarHeight = 40;
+const int kNTPMinimumBookmarkBarHeight = 40;
#endif
// The height of Bookmarks Bar, when attached to the toolbar.
@@ -20,9 +20,9 @@ const int kNTPBookmarkBarHeight = 40;
// points) because of the visual overlap with the main toolbar. When using this
// to compute values other than the actual height of the toolbar, be sure to add
// |kVisualHeightOffset|.
-const int kBookmarkBarHeight = 26;
+const int kMinimumBookmarkBarHeight = 26;
#elif defined(TOOLKIT_VIEWS)
-const int kBookmarkBarHeight = 28;
+const int kMinimumBookmarkBarHeight = 28;
#endif
} // namespace chrome

Powered by Google App Engine
This is Rietveld 408576698