Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Unified Diff: chrome/browser/ui/views/bookmarks/bookmark_bar_view.h

Issue 2208973003: Add some extra height to bookmark bar if the font wants to be larger (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/bookmarks/bookmark_bar_view.h
diff --git a/chrome/browser/ui/views/bookmarks/bookmark_bar_view.h b/chrome/browser/ui/views/bookmarks/bookmark_bar_view.h
index a48121452027e998f259762e2c1fa6af67f41cb4..4687a266240a573f3447f1d10819720ac5fe1981 100644
--- a/chrome/browser/ui/views/bookmarks/bookmark_bar_view.h
+++ b/chrome/browser/ui/views/bookmarks/bookmark_bar_view.h
@@ -385,6 +385,10 @@ class BookmarkBarView : public views::AccessiblePaneView,
SchedulePaint();
}
+ // Calculate and return the extra padding added to the preferred height if the
+ // font is taller than normal. (eg. Hindi text).
+ int GetExtraFontPadding() const;
+
// Needed to react to kShowAppsShortcutInBookmarkBar changes.
PrefChangeRegistrar profile_pref_registrar_;
@@ -459,6 +463,9 @@ class BookmarkBarView : public views::AccessiblePaneView,
// Factory used to delay showing of the drop menu.
base::WeakPtrFactory<BookmarkBarView> show_folder_method_factory_;
+ // Extra padding for the height when the font wants to be larger than normal.
+ static int extra_font_padding_;
+
DISALLOW_COPY_AND_ASSIGN(BookmarkBarView);
};

Powered by Google App Engine
This is Rietveld 408576698