Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Side by Side Diff: chrome/browser/ui/bookmarks/bookmark_bar_constants.h

Issue 2208973003: Add some extra height to bookmark bar if the font wants to be larger (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed #if in header not used for iOS & Android Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/bookmarks/bookmark_bar_constants.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_BOOKMARKS_BOOKMARK_BAR_CONSTANTS_H_ 5 #ifndef CHROME_BROWSER_UI_BOOKMARKS_BOOKMARK_BAR_CONSTANTS_H_
6 #define CHROME_BROWSER_UI_BOOKMARKS_BOOKMARK_BAR_CONSTANTS_H_ 6 #define CHROME_BROWSER_UI_BOOKMARKS_BOOKMARK_BAR_CONSTANTS_H_
7 7
8 #include "build/build_config.h" 8 #include "build/build_config.h"
9 9
10 namespace chrome { 10 namespace chrome {
11 11
12 // The height of Bookmarks Bar, when visible in "New Tab Page" mode. 12 // The height of Bookmarks Bar, when visible in "New Tab Page" mode.
13 #if defined(TOOLKIT_VIEWS) || defined(OS_MACOSX) 13 const int kNTPMinimumBookmarkBarHeight = 40;
14 const int kNTPBookmarkBarHeight = 40;
15 #endif
16 14
17 // The height of Bookmarks Bar, when attached to the toolbar. 15 // The height of Bookmarks Bar, when attached to the toolbar.
Evan Stade 2016/08/17 15:47:29 nit: update comments
kylix_rd 2016/08/23 20:28:17 Done.
18 #if defined(OS_MACOSX) 16 #if defined(OS_MACOSX)
19 // This is actually a little smaller than it should be (by |kVisualHeightOffset| 17 // This is actually a little smaller than it should be (by |kVisualHeightOffset|
20 // points) because of the visual overlap with the main toolbar. When using this 18 // points) because of the visual overlap with the main toolbar. When using this
21 // to compute values other than the actual height of the toolbar, be sure to add 19 // to compute values other than the actual height of the toolbar, be sure to add
22 // |kVisualHeightOffset|. 20 // |kVisualHeightOffset|.
23 const int kBookmarkBarHeight = 26; 21 const int kMinimumBookmarkBarHeight = 26;
24 #elif defined(TOOLKIT_VIEWS) 22 #elif defined(TOOLKIT_VIEWS)
25 const int kBookmarkBarHeight = 28; 23 const int kMinimumBookmarkBarHeight = 28;
26 #endif 24 #endif
27 25
28 } // namespace chrome 26 } // namespace chrome
29 27
30 #endif // CHROME_BROWSER_UI_BOOKMARKS_BOOKMARK_BAR_CONSTANTS_H_ 28 #endif // CHROME_BROWSER_UI_BOOKMARKS_BOOKMARK_BAR_CONSTANTS_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/bookmarks/bookmark_bar_constants.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698