Add some extra height to bookmark bar if the font wants to be larger

chrome/browser/ui/webui/ntp/ntp_resource_cache.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/ntp/ntp_resource_cache.h"
 
 #include <string>
 #include <vector>
 
 #include "base/command_line.h"
@@ skipping 121 matching lines @@
   }
 
   int alignment = theme_provider.GetDisplayProperty(
       ThemeProperties::NTP_BACKGROUND_ALIGNMENT);
 
   if (bar_attached)
     return ThemeProperties::AlignmentToString(alignment);
 
   if (alignment & ThemeProperties::ALIGN_TOP) {
     // The bar is detached, so we must offset the background by the bar size
     // if it's a top-aligned bar.

[Evan Stade, 2016/08/17 06:36:35]

ruh roh. This is now broken since we aren't hard-coding the bar size.

[kylix_rd, 2016/08/17 15:39:02]

It is only broken if kNTPMinimumBookmarkBarHeight isn't sufficiently tall to to
display the fonts. Possible, but not likely, IMO.

It doesn't look like this function has enough information to determine the
proper offset if the NTP bookmark bar is taller than
kNTPMinimumBookmarkBarHeight.

I can investigate.

[Evan Stade, 2016/08/17 15:47:29]

oh wait, that's right, the ntp version is taller and shouldn't have a problem
even with Hindi. Forgive me if this was covered up thread, but why do we need to
apply the same logic to the NTP bookmark bar then, instead of leaving its size
hardcoded (to simplify stuff like this)?

now that I look in the other files, it seems like you haven't changed how this
is used, so why the name change?

[kylix_rd, 2016/08/17 16:13:51]

Consistency? A little overzealous? Good question. I'll change it back.

-    int offset = chrome::kNTPBookmarkBarHeight;
+    int offset = chrome::kNTPMinimumBookmarkBarHeight;
 
     if (alignment & ThemeProperties::ALIGN_LEFT)
       return "left " + base::IntToString(-offset) + "px";
     else if (alignment & ThemeProperties::ALIGN_RIGHT)
       return "right " + base::IntToString(-offset) + "px";
     return "center " + base::IntToString(-offset) + "px";
   }
 
   return ThemeProperties::AlignmentToString(alignment);
 }
@@ skipping 449 matching lines @@
   // Get our template.
   static const base::StringPiece new_tab_theme_css(
       ResourceBundle::GetSharedInstance().GetRawDataResource(
           IDR_NEW_TAB_4_THEME_CSS));
 
   // Create the string from our template and the replacements.
   std::string css_string =
       ui::ReplaceTemplateExpressions(new_tab_theme_css, substitutions);
   new_tab_css_ = base::RefCountedString::TakeString(&css_string);
 }