Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Unified Diff: third_party/WebKit/LayoutTests/inspector/tracing/timeline-style/timeline-style-recalc-with-invalidator-invalidations.html

Issue 2208963002: [DevTools] Removed InspectorTest.invokeFunctionInPageAsync (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove-promise-from-other-tests
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/inspector/tracing/timeline-style/timeline-style-recalc-with-invalidator-invalidations.html
diff --git a/third_party/WebKit/LayoutTests/inspector/tracing/timeline-style/timeline-style-recalc-with-invalidator-invalidations.html b/third_party/WebKit/LayoutTests/inspector/tracing/timeline-style/timeline-style-recalc-with-invalidator-invalidations.html
index 5ab8b8e8e6840e34495c613603503cfff443b60c..6b87f936f9a716a138f8e59b196eddb44d5744e7 100644
--- a/third_party/WebKit/LayoutTests/inspector/tracing/timeline-style/timeline-style-recalc-with-invalidator-invalidations.html
+++ b/third_party/WebKit/LayoutTests/inspector/tracing/timeline-style/timeline-style-recalc-with-invalidator-invalidations.html
@@ -4,8 +4,10 @@
<script src="../../../http/tests/inspector/inspector-test.js"></script>
<script src="../../../http/tests/inspector/timeline-test.js"></script>
<script>
-function changeStylesAndDisplay(callback)
+function changeStylesAndDisplay()
{
+ var callback;
+ var promise = new Promise((fulfill) => callback = fulfill);
requestAnimationFrame(function() {
document.getElementById("testElementOne").className = "red";
document.getElementById("testElementTwo").className = "red";
@@ -13,10 +15,13 @@ function changeStylesAndDisplay(callback)
if (window.testRunner)
testRunner.layoutAndPaintAsyncThen(callback);
});
+ return promise;
caseq 2016/08/05 17:56:43 replace with generateFrames
kozy 2016/08/10 01:21:15 Done.
}
-function changeMultipleStylesAndDisplay(callback)
+function changeMultipleStylesAndDisplay()
{
+ var callback;
+ var promise = new Promise((fulfill) => callback = fulfill);
requestAnimationFrame(function() {
var elementOne = document.getElementById("testElementOne");
var elementTwo = document.getElementById("testElementTwo");
@@ -33,10 +38,13 @@ function changeMultipleStylesAndDisplay(callback)
if (window.testRunner)
testRunner.layoutAndPaintAsyncThen(callback);
});
+ return promise;
caseq 2016/08/05 17:56:43 ditto
kozy 2016/08/10 01:21:15 Done.
}
-function changeMultipleSubframeStylesAndDisplay(callback)
+function changeMultipleSubframeStylesAndDisplay()
{
+ var callback;
+ var promise = new Promise((fulfill) => callback = fulfill);
requestAnimationFrame(function() {
var innerDocument = frames[0].document;
var elementOne = innerDocument.getElementById("testElementOne");
@@ -54,6 +62,7 @@ function changeMultipleSubframeStylesAndDisplay(callback)
if (window.testRunner)
testRunner.layoutAndPaintAsyncThen(callback);
});
+ return promise;
caseq 2016/08/05 17:56:43 ditto
kozy 2016/08/10 01:21:15 Done.
}
function test()

Powered by Google App Engine
This is Rietveld 408576698