third_party/WebKit/LayoutTests/inspector/tracing/timeline-network/timeline-network-resource.html - Issue 2208963002: [DevTools] Removed InspectorTest.invokeFunctionInPageAsync

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/inspector/tracing/timeline-network/timeline-network-resource.html

Issue 2208963002: [DevTools] Removed InspectorTest.invokeFunctionInPageAsync (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove-promise-from-other-tests

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/inspector/tracing/timeline-network/timeline-network-received-data.html ('K') | « third_party/WebKit/LayoutTests/inspector/tracing/timeline-network/timeline-network-received-data.html ('k') | third_party/WebKit/LayoutTests/inspector/tracing/timeline-network/timeline-network-resource-details.html » ('j') | third_party/WebKit/LayoutTests/inspector/tracing/timeline-network/timeline-network-resource-details.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/inspector/tracing/timeline-network/timeline-network-resource.html

diff --git a/third_party/WebKit/LayoutTests/inspector/tracing/timeline-network/timeline-network-resource.html b/third_party/WebKit/LayoutTests/inspector/tracing/timeline-network/timeline-network-resource.html

index e5de92e0b13d769e6a6de8735cb617bf10469b39..ed86b889103cf70e338e6cd573bbcb10d883c531 100644

--- a/third_party/WebKit/LayoutTests/inspector/tracing/timeline-network/timeline-network-resource.html

+++ b/third_party/WebKit/LayoutTests/inspector/tracing/timeline-network/timeline-network-resource.html

@@ -6,12 +6,15 @@

var scriptUrl = "timeline-network-resource.js";

-function performActions(callback)

+function performActions()

{

+ var callback;

caseq 2016/08/05 17:56:42 drop this, assign directly to window.timelineNetwo

kozy 2016/08/10 01:21:14 Done.

+ var promise = new Promise((fulfill) => callback = fulfill);

window.timelineNetworkResourceEvaluated = callback;

var script = document.createElement("script");

script.src = scriptUrl;

document.body.appendChild(script);

+ return promise;

}

function test()