Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: third_party/WebKit/LayoutTests/inspector/tracing/timeline-misc/timeline-event-causes.html

Issue 2208963002: [DevTools] Removed InspectorTest.invokeFunctionInPageAsync (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove-promise-from-other-tests
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/inspector/tracing/timeline-misc/timeline-event-causes.html
diff --git a/third_party/WebKit/LayoutTests/inspector/tracing/timeline-misc/timeline-event-causes.html b/third_party/WebKit/LayoutTests/inspector/tracing/timeline-misc/timeline-event-causes.html
index 5b98db768890b10d11ff5dd085eed162f480eb83..ee66a190a7495fa6c935e177d1495f932dd53319 100644
--- a/third_party/WebKit/LayoutTests/inspector/tracing/timeline-misc/timeline-event-causes.html
+++ b/third_party/WebKit/LayoutTests/inspector/tracing/timeline-misc/timeline-event-causes.html
@@ -15,9 +15,12 @@ function test()
InspectorTest.runTestSuite([
function testTimerInstall(next)
{
- function setTimeoutFunction(callback)
+ function setTimeoutFunction()
{
+ var callback;
+ var promise = new Promise((fulfill) => callback = fulfill);
setTimeout(callback, 0);
caseq 2016/08/05 17:56:42 inline into new Promise(...)
kozy 2016/08/10 01:21:14 We need to have good closure around setTimeout for
+ return promise;
}
var source = setTimeoutFunction.toString();
@@ -44,7 +47,10 @@ function test()
{
function requestAnimationFrameFunction(callback)
{
+ var callback;
+ var promise = new Promise((fulfill) => callback = fulfill);
requestAnimationFrame(callback);
caseq 2016/08/05 17:56:42 ditto.
kozy 2016/08/10 01:21:14 Acknowledged.
+ return promise;
}
var source = requestAnimationFrameFunction.toString();

Powered by Google App Engine
This is Rietveld 408576698