Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Unified Diff: third_party/WebKit/LayoutTests/inspector-protocol/timeline/timeline-raf.html

Issue 2208963002: [DevTools] Removed InspectorTest.invokeFunctionInPageAsync (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove-promise-from-other-tests
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/inspector-protocol/timeline/timeline-raf.html
diff --git a/third_party/WebKit/LayoutTests/inspector-protocol/timeline/timeline-raf.html b/third_party/WebKit/LayoutTests/inspector-protocol/timeline/timeline-raf.html
index 61d0a958beacfc6f46d1466313c976fde00d60cb..5334f311a919253ed72a0c59473977b1024a140d 100644
--- a/third_party/WebKit/LayoutTests/inspector-protocol/timeline/timeline-raf.html
+++ b/third_party/WebKit/LayoutTests/inspector-protocol/timeline/timeline-raf.html
@@ -4,8 +4,10 @@
<script type="text/javascript" src="../../http/tests/inspector-protocol/tracing-test.js"></script>
<script>
-function performActions(callback)
+function performActions()
{
+ var callback;
+ var promise = new Promise((fulfill) => callback = fulfill);
var rafId1 = requestAnimationFrame(function()
{
evaluateInFrontend("InspectorTest.testFunctionRequestAnimationFrame(" + rafId1 + ", " + rafId2 + ")");
caseq 2016/08/05 17:56:42 nit: this could be re-written in a much better way
kozy 2016/08/10 01:21:14 Done.
@@ -14,6 +16,7 @@ function performActions(callback)
var rafId2 = requestAnimationFrame(function() { });
cancelAnimationFrame(rafId2);
+ return promise;
}
function test()

Powered by Google App Engine
This is Rietveld 408576698