pkg/analyzer/test/generated/strong_mode_test.dart - Issue 2208953002: fix #25944, improve Future.then inference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analyzer/test/generated/strong_mode_test.dart

Issue 2208953002: fix #25944, improve Future.then inference (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: cleanup unused code Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« pkg/analyzer/lib/src/generated/type_system.dart ('K') | « pkg/analyzer/lib/src/generated/type_system.dart ('k') | pkg/analyzer/test/src/context/mock_sdk.dart » ('j') | pkg/analyzer/test/src/task/strong/inferred_type_test.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analyzer/test/generated/strong_mode_test.dart

diff --git a/pkg/analyzer/test/generated/strong_mode_test.dart b/pkg/analyzer/test/generated/strong_mode_test.dart

index 75f4ea97f808527b2b86d832394b195d056a5707..8a08c5329ed6910faa508fecf9141211cc2afc93 100644

--- a/pkg/analyzer/test/generated/strong_mode_test.dart

+++ b/pkg/analyzer/test/generated/strong_mode_test.dart

@@ -121,9 +121,7 @@ class StrongModeDownwardsInferenceTest extends ResolverTestCase {

check("f2", _isFutureOfDynamic);

check("f3", _isFutureOfInt);

- // This should be int when we handle the implicit Future<T> | T union

- // https://github.com/dart-lang/sdk/issues/25322

- check("f4", _isFutureOfDynamic);

+ check("f4", _isFutureOfInt);

check("f5", _isFutureOfInt);

check("g0", _isFutureOfDynamic);

@@ -131,9 +129,7 @@ class StrongModeDownwardsInferenceTest extends ResolverTestCase {

check("g2", _isFutureOfDynamic);

check("g3", _isFutureOfInt);

- // This should be int when we handle the implicit Future<T> | T union

- // https://github.com/dart-lang/sdk/issues/25322

- check("g4", _isFutureOfDynamic);

+ check("g4", _isFutureOfInt);

check("g5", _isFutureOfInt);

}

@@ -181,9 +177,7 @@ class StrongModeDownwardsInferenceTest extends ResolverTestCase {

check("f2", _isFutureOfDynamic);

check("f3", _isFutureOfInt);

- // This should be int when we handle the implicit Future<T> | T union

- // https://github.com/dart-lang/sdk/issues/25322

- check("f4", _isFutureOfDynamic);

+ check("f4", _isFutureOfInt);

check("f5", _isFutureOfInt);

check("g0", _isFutureOfDynamic);

@@ -191,9 +185,7 @@ class StrongModeDownwardsInferenceTest extends ResolverTestCase {

check("g2", _isFutureOfDynamic);

check("g3", _isFutureOfInt);

- // This should be int when we handle the implicit Future<T> | T union

- // https://github.com/dart-lang/sdk/issues/25322

- check("g4", _isFutureOfDynamic);

+ check("g4", _isFutureOfInt);

check("g5", _isFutureOfInt);

}