Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2208943002: Revert of Implement filter effects in Core Animation using CAFilters. (Closed)

Created:
4 years, 4 months ago by erikchen
Modified:
4 years, 4 months ago
Reviewers:
piman, ccameron
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@temp50_base
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Implement filter effects in Core Animation using CAFilters. (patchset #4 id:60001 of https://codereview.chromium.org/2186693002/ ) Reason for revert: The new implementation for filter effects in the CA compositor doesn't rely on CA filters, which are fundamentally flawed. See https://bugs.chromium.org/p/chromium/issues/detail?id=581526#c29 for more details. Original issue's description: > Implement filter effects in Core Animation using CAFilters. > > Filter effects are converted into CAFilters, which are applied to the CALayer. > > BUG=581526 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > > Committed: https://crrev.com/3bf2141da52df2a38288455c142e5dd164253130 > Cr-Commit-Position: refs/heads/master@{#407951} TBR=piman@chromium.org,ccameron@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=581526 Committed: https://crrev.com/7490bda13d8646a6225b45bb45126be71e19358c Cr-Commit-Position: refs/heads/master@{#409826}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -271 lines) Patch
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/accelerated_widget_mac/ca_layer_tree_unittest_mac.mm View 3 chunks +2 lines, -33 lines 0 comments Download
M ui/accelerated_widget_mac/ca_renderer_layer_tree.h View 3 chunks +1 line, -6 lines 0 comments Download
M ui/accelerated_widget_mac/ca_renderer_layer_tree.mm View 11 chunks +6 lines, -221 lines 0 comments Download
M ui/gl/ca_renderer_layer_params.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/gl/ca_renderer_layer_params.cc View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
erikchen
Created Revert of Implement filter effects in Core Animation using CAFilters.
4 years, 4 months ago (2016-08-04 00:14:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2208943002/1
4 years, 4 months ago (2016-08-04 00:15:33 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/115799)
4 years, 4 months ago (2016-08-04 01:34:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2208943002/1
4 years, 4 months ago (2016-08-04 17:11:04 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-04 17:46:05 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-04 17:47:26 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7490bda13d8646a6225b45bb45126be71e19358c
Cr-Commit-Position: refs/heads/master@{#409826}

Powered by Google App Engine
This is Rietveld 408576698