content/browser/frame_host/render_frame_host_manager.cc - Issue 2208933002: Don't load subframe history items if a client redirect occurs during load.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_frame_host_manager.cc

Issue 2208933002: Don't load subframe history items if a client redirect occurs during load. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Limit to subframe case. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/frame_host/render_frame_host_manager.cc

diff --git a/content/browser/frame_host/render_frame_host_manager.cc b/content/browser/frame_host/render_frame_host_manager.cc

index e6f7b81f2717555d1f68550e02c0a93abc3f4237..6e33a629383190e33f19f24dcca72a011c0106e7 100644

--- a/content/browser/frame_host/render_frame_host_manager.cc

+++ b/content/browser/frame_host/render_frame_host_manager.cc

@@ -2317,6 +2317,7 @@ void RenderFrameHostManager::UpdatePendingWebUIOnCurrentFrameHost(

}

void RenderFrameHostManager::CancelPending() {

+ CHECK(pending_render_frame_host_);

TRACE_EVENT1("navigation", "RenderFrameHostManager::CancelPending",

"FrameTreeNode id", frame_tree_node_->frame_tree_node_id());

render_frame_host_->ClearPendingWebUI();

« no previous file with comments | « content/browser/frame_host/render_frame_host_manager.h ('k') | content/common/frame_messages.h » ('j') | content/renderer/render_frame_impl.cc » ('J')