Use sse4.2 CRC32 instructions to hash when available.

Use sse4.2 CRC32 instructions to hash when available.

About 9x faster than Murmur3 for long inputs.

Most of this is a mechanical change from SkChecksum::Murmur3(...) to SkOpts::hash(...).

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2208903002
CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot;master.client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot

Committed: https://skia.googlesource.com/skia/+/4e97607d9a1cef66fac16f347c5ca813ec4f9515

[mtklein_C, 2016-08-03 22:56:06]

Description was changed from

==========
Use sse4.2 CRC32 instructions to hash when available.

~3x speedup.

BUG=skia:
==========

to

==========
Use sse4.2 CRC32 instructions to hash when available.

~3x speedup.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2208903002
CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
==========

[mtklein_C, 2016-08-04 00:01:45]

Description was changed from

==========
Use sse4.2 CRC32 instructions to hash when available.

~3x speedup.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2208903002
CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
==========

to

==========
Use sse4.2 CRC32 instructions to hash when available.

~3x speedup.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2208903002
CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot;master.client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot
==========

[mtklein, 2016-08-04 00:29:03]

Description was changed from

==========
Use sse4.2 CRC32 instructions to hash when available.

~3x speedup.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2208903002
CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot;master.client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot
==========

to

==========
Use sse4.2 CRC32 instructions to hash when available.

~4x speedup.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2208903002
CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot;master.client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot
==========

[mtklein, 2016-08-04 00:29:11]

Description was changed from

==========
Use sse4.2 CRC32 instructions to hash when available.

~4x speedup.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2208903002
CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot;master.client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot
==========

to

==========
Use sse4.2 CRC32 instructions to hash when available.

~4x speedup over Murmur3.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2208903002
CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot;master.client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot
==========

[mtklein_C, 2016-08-04 00:53:17]

Description was changed from

==========
Use sse4.2 CRC32 instructions to hash when available.

~4x speedup over Murmur3.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2208903002
CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot;master.client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot
==========

to

==========
Use sse4.2 CRC32 instructions to hash when available.

~4x speedup over Murmur3.

Most of this is a mechanical change from SkChecksum::Murmur3(...) to
SkOpts::hash(...).

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2208903002
CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot;master.client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot
==========

[mtklein_C, 2016-08-04 01:02:42]

The CQ bit was checked by mtklein@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-04 01:02:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-04 01:02:54]

There were warnings when CQ was processing your CL:
 * CQ is not running the Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot trybot,
per your CQ_INCLUDE_TRYBOTS flag request. That bot was already specified, with
these tests: ['defaulttests']

[commit-bot: I haz the power, 2016-08-04 01:05:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-04 01:05:54]

Dry run: Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on master.client.skia
(JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on
master.client.skia (JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)

[mtklein_C, 2016-08-04 01:07:44]

The CQ bit was checked by mtklein@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-04 01:07:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-04 01:07:55]

There were warnings when CQ was processing your CL:
 * CQ is not running the Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot trybot,
per your CQ_INCLUDE_TRYBOTS flag request. That bot was already specified, with
these tests: ['defaulttests']

[commit-bot: I haz the power, 2016-08-04 01:10:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-04 01:10:45]

Dry run: Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on master.client.skia
(JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)

[mtklein_C, 2016-08-04 01:31:03]

Description was changed from

==========
Use sse4.2 CRC32 instructions to hash when available.

~4x speedup over Murmur3.

Most of this is a mechanical change from SkChecksum::Murmur3(...) to
SkOpts::hash(...).

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2208903002
CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot;master.client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot
==========

to

==========
Use sse4.2 CRC32 instructions to hash when available.

About 9x faster than Murmur3.

Most of this is a mechanical change from SkChecksum::Murmur3(...) to
SkOpts::hash(...).

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2208903002
CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot;master.client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot
==========

[mtklein_C, 2016-08-04 01:34:58]

The CQ bit was checked by mtklein@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-04 01:35:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-04 01:35:04]

There were warnings when CQ was processing your CL:
 * CQ is not running the Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot trybot,
per your CQ_INCLUDE_TRYBOTS flag request. That bot was already specified, with
these tests: ['defaulttests']

[commit-bot: I haz the power, 2016-08-04 01:37:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-04 01:37:53]

Dry run: Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot on
master.client.skia (JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)
  Build-Ubuntu-Clang-x86_64-Debug-Trybot on master.client.skia.compile
(JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x...)
  Build-Ubuntu-GCC-x86_64-Release-Trybot on master.client.skia.compile
(JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86...)

[mtklein_C, 2016-08-04 01:50:12]

The CQ bit was checked by mtklein@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-04 01:50:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-04 01:50:24]

There were warnings when CQ was processing your CL:
 * CQ is not running the Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot trybot,
per your CQ_INCLUDE_TRYBOTS flag request. That bot was already specified, with
these tests: ['defaulttests']

[commit-bot: I haz the power, 2016-08-04 01:54:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-04 01:54:17]

Dry run: Exceeded global retry quota

[mtklein_C, 2016-08-04 01:55:25]

The CQ bit was checked by mtklein@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-04 01:55:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-04 01:55:39]

There were warnings when CQ was processing your CL:
 * CQ is not running the Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot trybot,
per your CQ_INCLUDE_TRYBOTS flag request. That bot was already specified, with
these tests: ['defaulttests']

[mtklein_C, 2016-08-04 02:01:50]

The CQ bit was checked by mtklein@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-04 02:01:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-04 02:02:22]

There were warnings when CQ was processing your CL:
 * CQ is not running the Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot trybot,
per your CQ_INCLUDE_TRYBOTS flag request. That bot was already specified, with
these tests: ['defaulttests']

[commit-bot: I haz the power, 2016-08-04 02:03:40]

There were warnings when CQ was processing your CL:
 * CQ is not running the Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot trybot,
per your CQ_INCLUDE_TRYBOTS flag request. That bot was already specified, with
these tests: ['defaulttests']

[commit-bot: I haz the power, 2016-08-04 02:18:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-04 02:18:01]

Dry run: Try jobs failed on following builders:
  Build-Win-MSVC-x86_64-Debug-Trybot on master.client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)

[mtklein_C, 2016-08-04 02:25:32]

The CQ bit was checked by mtklein@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-04 02:25:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-04 02:25:41]

There were warnings when CQ was processing your CL:
 * CQ is not running the Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot trybot,
per your CQ_INCLUDE_TRYBOTS flag request. That bot was already specified, with
these tests: ['defaulttests']

[commit-bot: I haz the power, 2016-08-04 02:27:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-04 02:27:37]

Dry run: Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on master.client.skia
(JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot on
master.client.skia (JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)
  Test-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-Trybot on
master.client.skia (JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-ShuttleA-GPU...)
  Build-Ubuntu-Clang-x86_64-Debug-GN-Trybot on master.client.skia.compile
(JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x...)

[mtklein_C, 2016-08-04 02:28:59]

The CQ bit was checked by mtklein@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-04 02:29:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-04 02:29:08]

There were warnings when CQ was processing your CL:
 * CQ is not running the Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot trybot,
per your CQ_INCLUDE_TRYBOTS flag request. That bot was already specified, with
these tests: ['defaulttests']

[commit-bot: I haz the power, 2016-08-04 02:31:01]

There were warnings when CQ was processing your CL:
 * CQ is not running the Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot trybot,
per your CQ_INCLUDE_TRYBOTS flag request. That bot was already specified, with
these tests: ['defaulttests']

[mtklein_C, 2016-08-04 02:47:28]

mtklein@chromium.org changed reviewers:
+ herb@google.com

[mtklein_C, 2016-08-04 02:47:30]

Hello old friend!

[commit-bot: I haz the power, 2016-08-04 02:53:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-04 02:53:51]

Dry run: This issue passed the CQ dry run.

[mtklein, 2016-08-04 12:07:07]

mtklein@google.com changed reviewers:
+ egdaniel@google.com, mtklein@google.com

[mtklein, 2016-08-04 12:07:08]

Greg, SkChecksum::Murmur3() was showing up hot on your profile right?  Think you
can patch this in and take a quick before/after look at where
SkChecksum::Murmur3() was on your profile and where sse42::hash() ends up?

Note the caveats so far: x86-64 only.  I can expand this to 32-bit x86 and
64-bit ARM.  The implementations will all be significantly different, so I don't
know if the speedups will match, but they'll all definitely speed up
significantly.  

Poor 32-bit ARM and pre-2008 x86 will be left out of the fun.  :(

[mtklein, 2016-08-04 13:18:12]

Description was changed from

==========
Use sse4.2 CRC32 instructions to hash when available.

About 9x faster than Murmur3.

Most of this is a mechanical change from SkChecksum::Murmur3(...) to
SkOpts::hash(...).

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2208903002
CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot;master.client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot
==========

to

==========
Use sse4.2 CRC32 instructions to hash when available.

About 9x faster than Murmur3 for long inputs.

Most of this is a mechanical change from SkChecksum::Murmur3(...) to
SkOpts::hash(...).

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2208903002
CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot;master.client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot
==========

[egdaniel, 2016-08-05 19:45:00]

In general this looks good to me, but you should confirm with herb whose don't
more of this type of stuff before.

https://codereview.chromium.org/2208903002/diff/340001/src/opts/SkChecksum_op...
File src/opts/SkChecksum_opts.h (right):

https://codereview.chromium.org/2208903002/diff/340001/src/opts/SkChecksum_op...
src/opts/SkChecksum_opts.h:44: while (steps --> 0) {
how kosher are "goes to" operators in skia?

[mtklein, 2016-08-05 20:16:37]

https://codereview.chromium.org/2208903002/diff/340001/src/opts/SkChecksum_op...
File src/opts/SkChecksum_opts.h (right):

https://codereview.chromium.org/2208903002/diff/340001/src/opts/SkChecksum_op...
src/opts/SkChecksum_opts.h:44: while (steps --> 0) {
On 2016/08/05 19:45:00, egdaniel wrote:
> how kosher are "goes to" operators in skia?

I personally find it the clearest way to express "loop this many times, and I
won't be needing an index inside the loop."  I don't mind writing it (steps-- >
0) if you prefer.

On the other hand, I have nothing but contempt for (0 <-- steps).  Things in
left to right code should point left to right.  ;)

[mtklein, 2016-08-08 14:53:17]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2016-08-08 14:53:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-08 14:53:24]

There were warnings when CQ was processing your CL:
 * CQ is not running the Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot trybot,
per your CQ_INCLUDE_TRYBOTS flag request. That bot was already specified, with
these tests: ['defaulttests']

[commit-bot: I haz the power, 2016-08-08 14:54:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-08 14:54:52]

Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot on
master.client.skia (JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)
  Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot on master.client.skia.compile
(JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...)
  Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on master.client.skia.compile
(JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...)
  skia_presubmit-Trybot on master.client.skia.fyi (JOB_FAILED,
http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)

[herb_g, 2016-08-08 15:37:55]

lgtm

[mtklein_C, 2016-08-08 15:43:27]

rebase

[mtklein, 2016-08-08 15:44:41]

The CQ bit was checked by mtklein@google.com

[mtklein, 2016-08-08 15:44:42]

The patchset sent to the CQ was uploaded after l-g-t-m from herb@google.com
Link to the patchset: https://codereview.chromium.org/2208903002/#ps360001
(title: "rebase")

[commit-bot: I haz the power, 2016-08-08 15:44:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-08 15:44:49]

There were warnings when CQ was processing your CL:
 * CQ is not running the Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot trybot,
per your CQ_INCLUDE_TRYBOTS flag request. That bot was already specified, with
these tests: ['defaulttests']

[commit-bot: I haz the power, 2016-08-08 16:01:09]

There were warnings when CQ was processing your CL:
 * CQ is not running the Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot trybot,
per your CQ_INCLUDE_TRYBOTS flag request. That bot was already specified, with
these tests: ['defaulttests']

[commit-bot: I haz the power, 2016-08-08 16:06:30]

Description was changed from

==========
Use sse4.2 CRC32 instructions to hash when available.

About 9x faster than Murmur3 for long inputs.

Most of this is a mechanical change from SkChecksum::Murmur3(...) to
SkOpts::hash(...).

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2208903002
CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot;master.client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot
==========

to

==========
Use sse4.2 CRC32 instructions to hash when available.

About 9x faster than Murmur3 for long inputs.

Most of this is a mechanical change from SkChecksum::Murmur3(...) to
SkOpts::hash(...).

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2208903002
CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot;master.client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot

Committed:
https://skia.googlesource.com/skia/+/4e97607d9a1cef66fac16f347c5ca813ec4f9515
==========

[commit-bot: I haz the power, 2016-08-08 16:06:31]

Committed patchset #19 (id:360001) as
https://skia.googlesource.com/skia/+/4e97607d9a1cef66fac16f347c5ca813ec4f9515

[fmalita_google_do_not_use, 2016-08-08 19:48:25]

On 2016/08/08 16:06:31, commit-bot: I haz the power wrote:
> Committed patchset #19 (id:360001) as
> https://skia.googlesource.com/skia/+/4e97607d9a1cef66fac16f347c5ca813ec4f9515

Build failures:
https://build.chromium.org/p/client.skia/builders/Perf-Ubuntu-GCC-GCE-CPU-AVX...


FAILED: /b/work/skia/tools/../third_party/externals/llvm/out/bin/clang++ -MMD
-MF obj/tests/dm.ChecksumTest.o.d -DSK_INTERNAL -DSK_GAMMA_APPLY_TO_A8
-DQT_NO_KEYWORDS -DSK_ALLOW_STATIC_GLOBAL_INITIALIZERS=1 -DSK_SUPPORT_GPU=0
-DSK_FORCE_DISTANCE_FIELD_TEXT=0 -DSK_HAS_GIF_LIBRARY -DSK_HAS_JPEG_LIBRARY
-DSK_HAS_PNG_LIBRARY -DSK_HAS_WEBP_LIBRARY -DSK_IS_BOT -DSK_CODEC_DECODES_RAW
-DSK_TEST_QCMS -DSK_SAMPLES_FOR_X -DSK_BUILD_FOR_UNIX -DSK_XML -DSK_DEBUG=1
-I../../../dm -I../../../gm -I../../../include/private -I../../../src/core
-I../../../src/effects -I../../../src/images -I../../../src/lazy
-I../../../src/utils -I../../../tools/debugger -I../../../tests
-I../../../include/client/android -I../../../src/effects/gradients
-I../../../src/pathops -I../../../src/pipe/utils -I../../../src/codec
-I../../../src/image -I../../../src/pdf -I../../../src/ports -I../../../src/sksl
-I../../../third_party/etc1 -I../../../tools/flags
-I../../../third_party/externals/jsoncpp/include -I../../../third_party/libpng
-I../../../include/c -I../../../include/config -I../../../include/core
-I../../../include/pathops -I../../../include/codec -I../../../include/android
-I../../../include/effects -I../../../include/images -I../../../include/ports
-I../../../third_party/qcms/src -I../../../src/sfnt -I../../../include/utils
-I../../../include/svg -I../../../experimental/svg/model -I../../../tools
-I../../../tools -I../../../tools/timer -I../../../include/xml
-I../../../experimental -I../../../include/gpu -I../../../src/gpu
-I../../../third_party/externals/zlib -fPIC -g -fno-exceptions -fstrict-aliasing
-Wall -Wextra -Winit-self -Wpointer-arith -Wsign-compare -Wvla
-Wno-unused-parameter -m64 -Werror -fsanitize=memory
-fno-sanitize-recover=memory
-fsanitize-blacklist=/b/work/skia/tools/xsan.blacklist -include
/b/work/skia/tools/xsan.blacklist -O1 -fsanitize-memory-track-origins
-Wstring-conversion -fno-omit-frame-pointer -fPIE -stdlib=libc++
-I/b/work/skia/tools/../third_party/externals/llvm/msan_out/include -std=c++11
-fno-threadsafe-statics -Wnon-virtual-dtor -Wno-unknown-warning-option
-Wno-deprecated -Wno-deprecated-register  -c ../../../tests/ChecksumTest.cpp -o
obj/tests/dm.ChecksumTest.o
../../../tests/ChecksumTest.cpp:41:24: error: use of undeclared identifier
'SkGoodHash'
    REPORTER_ASSERT(r, SkGoodHash()(( int32_t)4) ==  614249093);
                       ^
../../../tests/ChecksumTest.cpp:42:24: error: use of undeclared identifier
'SkGoodHash'
    REPORTER_ASSERT(r, SkGoodHash()((uint32_t)4) ==  614249093);
                       ^
2 errors generated.


Also, debug SampleApp crashes locally with 

../../include/gpu/GrResourceKey.h:135: fatal error:
"assert(fKey[kHash_MetaDataIdx] == GrResourceKeyHash(&fKey[kHash_MetaDataIdx] +
1, this->internalSize() - sizeof(uint32_t)))"