Issue 22089002: Clean some unuse code of unary negation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22089002: Clean some unuse code of unary negation (Closed)

Created:
7 years, 4 months ago by weiliang.lin2

Modified:
7 years, 4 months ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

More Reviews

Description

Clean some unuse code of unary negation R=svenpanne@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=16036

Patch Set 1 #

Total comments: 1

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -9 lines)			Patch
M	src/ast.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/code-stubs.cc	View	3 chunks	+0 lines, -7 lines	1 comment	Download
M	src/hydrogen.h	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Sven Panne

LGTM, I'll land it for you... https://codereview.chromium.org/22089002/diff/1/src/code-stubs.cc File src/code-stubs.cc (left): https://codereview.chromium.org/22089002/diff/1/src/code-stubs.cc#oldcode212 src/code-stubs.cc:212: return Builtins::UNARY_MINUS; I ...

7 years, 4 months ago (2013-08-05 06:22:43 UTC) #2

Sven Panne

7 years, 4 months ago (2013-08-05 06:34:31 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r16036 (presubmit successful).

Expand Messages | Collapse Messages