Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issue 2208883002: Added list of imports to library modules (needed in order to discover filepaths of summaries, allow… (Closed)

Created:
4 years, 4 months ago by priscillalee
Modified:
4 years, 4 months ago
CC:
dev-compiler+reviews_dartlang.org, Alan Knight, bmilligan
Base URL:
https://github.com/dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Added list of imports to library modules (needed in order to discover filepaths of summaries, allowing the dev_compiler to run in the browser). BUG= R=jacobr@google.com, jmesserly@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/73b9e73bec11431e48b22f75942acba923d37784

Patch Set 1 : Adding list of imports to dart_library modules. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M lib/runtime/dart_library.js View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
priscillalee
4 years, 4 months ago (2016-08-03 21:41:34 UTC) #3
Jacob
lgtm
4 years, 4 months ago (2016-08-03 21:43:57 UTC) #4
Jennifer Messerly
lgtm
4 years, 4 months ago (2016-08-03 22:47:15 UTC) #5
priscillalee
4 years, 4 months ago (2016-08-03 22:48:10 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:10001) manually as
73b9e73bec11431e48b22f75942acba923d37784 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698