[Tracing] Create TraceConfig JSON string parser in D8.

[Tracing] Create TraceConfig JSON string parser in D8.

BUG=v8:4561
LOG=N

Committed: https://crrev.com/0359e1f63ec7361e6dd659c8d09d19235aca39a1
Cr-Commit-Position: refs/heads/master@{#38553}

[lpy, 2016-08-03 21:05:35]

The CQ bit was checked by lpy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-03 21:05:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lpy, 2016-08-03 21:06:38]

lpy@chromium.org changed reviewers:
+ fmeawad@chromium.org

[lpy, 2016-08-03 21:06:39]

PTAL.

cc mattloring@ and rskang@.

[commit-bot: I haz the power, 2016-08-03 21:08:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-03 21:08:07]

Dry run: Try jobs failed on following builders:
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)
  v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)
  v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)
  v8_linux_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/10229)

[lpy, 2016-08-03 21:34:54]

The CQ bit was checked by lpy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-03 21:35:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lpy, 2016-08-03 21:35:23]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2016-08-03 21:55:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-03 21:55:13]

Dry run: This issue passed the CQ dry run.

[fmeawad, 2016-08-04 13:01:07]

https://codereview.chromium.org/2208873002/diff/20001/src/d8.cc
File src/d8.cc (right):

https://codereview.chromium.org/2208873002/diff/20001/src/d8.cc#newcode257
src/d8.cc:257: trace_config->GetIncludedCategories());
Instead of Getting the categories list, and appending to here, I would rather if
you use
AddIncludedCategory instead.

[lpy, 2016-08-04 17:48:30]

https://codereview.chromium.org/2208873002/diff/20001/src/d8.cc
File src/d8.cc (right):

https://codereview.chromium.org/2208873002/diff/20001/src/d8.cc#newcode257
src/d8.cc:257: trace_config->GetIncludedCategories());
On 2016/08/04 13:01:06, fmeawad wrote:
> Instead of Getting the categories list, and appending to here, I would rather
if
> you use
> AddIncludedCategory instead.

Then it will need to update categories list method to update two specific
categories list.

[lpy, 2016-08-05 21:09:01]

On 2016/08/04 17:48:30, lpy wrote:
> https://codereview.chromium.org/2208873002/diff/20001/src/d8.cc
> File src/d8.cc (right):
> 
> https://codereview.chromium.org/2208873002/diff/20001/src/d8.cc#newcode257
> src/d8.cc:257: trace_config->GetIncludedCategories());
> On 2016/08/04 13:01:06, fmeawad wrote:
> > Instead of Getting the categories list, and appending to here, I would
rather
> if
> > you use
> > AddIncludedCategory instead.
> 
> Then it will need to update categories list method to update two specific
> categories list.

sorry for the typo

Then it will need two update categories list method to update two specific
categories list.

[lpy, 2016-08-08 18:39:23]

The CQ bit was checked by lpy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-08 18:39:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lpy, 2016-08-08 18:39:56]

I updated the CL, ptal.

https://codereview.chromium.org/2208873002/diff/20001/src/d8.cc
File src/d8.cc (right):

https://codereview.chromium.org/2208873002/diff/20001/src/d8.cc#newcode257
src/d8.cc:257: trace_config->GetIncludedCategories());
On 2016/08/04 13:01:06, fmeawad wrote:
> Instead of Getting the categories list, and appending to here, I would rather
if
> you use
> AddIncludedCategory instead.

Done.

[commit-bot: I haz the power, 2016-08-08 19:08:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-08 19:08:37]

Dry run: This issue passed the CQ dry run.

[fmeawad, 2016-08-08 19:10:30]

On 2016/08/08 18:39:56, lpy wrote:
> I updated the CL, ptal.
> 
> https://codereview.chromium.org/2208873002/diff/20001/src/d8.cc
> File src/d8.cc (right):
> 
> https://codereview.chromium.org/2208873002/diff/20001/src/d8.cc#newcode257
> src/d8.cc:257: trace_config->GetIncludedCategories());
> On 2016/08/04 13:01:06, fmeawad wrote:
> > Instead of Getting the categories list, and appending to here, I would
rather
> if
> > you use
> > AddIncludedCategory instead.
> 
> Done.

LGTM.

Is there a place where we can add a test?

[lpy, 2016-08-08 19:28:52]

lpy@chromium.org changed reviewers:
+ yangguo@chromium.org

[lpy, 2016-08-08 19:28:53]

+ Yang@ for review.

PTAL.

fadi@: I don't think we have a place to add test for non-exposed class.

[Yang, 2016-08-10 05:58:25]

lgtm with one nit.

https://codereview.chromium.org/2208873002/diff/40001/src/d8.cc
File src/d8.cc (right):

https://codereview.chromium.org/2208873002/diff/40001/src/d8.cc#newcode277
src/d8.cc:277: strcmp(kIncludedCategoriesParam, property) == 0;
I don't think you need to do a strcmp here. A pointer comparison suffices.

[lpy, 2016-08-10 06:40:39]

The CQ bit was checked by lpy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-10 06:40:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 07:07:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 07:07:43]

Dry run: This issue passed the CQ dry run.

[lpy, 2016-08-10 17:09:33]

The CQ bit was checked by lpy@chromium.org

[lpy, 2016-08-10 17:09:34]

The patchset sent to the CQ was uploaded after l-g-t-m from
fmeawad@chromium.org, yangguo@chromium.org
Link to the patchset: https://codereview.chromium.org/2208873002/#ps60001
(title: "update")

[commit-bot: I haz the power, 2016-08-10 17:09:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 17:11:01]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-08-10 17:11:12]

Description was changed from

==========
[Tracing] Create TraceConfig JSON string parser in D8.

BUG=v8:4561
LOG=N
==========

to

==========
[Tracing] Create TraceConfig JSON string parser in D8.

BUG=v8:4561
LOG=N

Committed: https://crrev.com/0359e1f63ec7361e6dd659c8d09d19235aca39a1
Cr-Commit-Position: refs/heads/master@{#38553}
==========

[commit-bot: I haz the power, 2016-08-10 17:11:13]

Patchset 3 (id:??) landed as
https://crrev.com/0359e1f63ec7361e6dd659c8d09d19235aca39a1
Cr-Commit-Position: refs/heads/master@{#38553}