Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Issue 220883003: Fix "make arm asan=$CLANG" (Closed)

Created:
6 years, 8 months ago by Jakob Kummerow
Modified:
6 years, 8 months ago
Reviewers:
Jarin
CC:
v8-dev
Visibility:
Public.

Description

Fix "make arm asan=$CLANG" Bonus cleanup: remove a few duplicate compiler flags R=jarin@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20402

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -7 lines) Patch
M Makefile View 1 chunk +3 lines, -3 lines 0 comments Download
M build/toolchain.gypi View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Jakob Kummerow
PTAL.
6 years, 8 months ago (2014-04-01 12:07:22 UTC) #1
Jarin
lgtm
6 years, 8 months ago (2014-04-01 12:30:59 UTC) #2
Jakob Kummerow
6 years, 8 months ago (2014-04-01 12:53:14 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r20402 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698