third_party/WebKit/Source/platform/network/ResourceResponse.h - Issue 2208803002: Remove SCT counters from DevTools security panel

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/network/ResourceResponse.h

Issue 2208803002: Remove SCT counters from DevTools security panel (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/exported/WebURLResponse.cpp ('k') | third_party/WebKit/Source/platform/network/ResourceResponse.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/network/ResourceResponse.h

diff --git a/third_party/WebKit/Source/platform/network/ResourceResponse.h b/third_party/WebKit/Source/platform/network/ResourceResponse.h

index b9f3cfba13c782a9581b17b0d5ec1d983f19aabf..8202fa3eae0ae4507f2a674c9e3ba47fa9f49307 100644

--- a/third_party/WebKit/Source/platform/network/ResourceResponse.h

+++ b/third_party/WebKit/Source/platform/network/ResourceResponse.h

@@ -102,9 +102,6 @@ public:

DISALLOW_NEW();

SecurityDetails()

: certID(0)

- , numUnknownSCTs(0)

- , numInvalidSCTs(0)

- , numValidSCTs(0)

{

}

// All strings are human-readable values.

@@ -115,9 +112,6 @@ public:

// have a separate MAC value (i.e. if the cipher suite is AEAD).

String mac;

int certID;

- size_t numUnknownSCTs;

- size_t numInvalidSCTs;

- size_t numValidSCTs;

SignedCertificateTimestampList sctList;

};

@@ -218,7 +212,7 @@ public:

void setSecurityStyle(SecurityStyle securityStyle) { m_securityStyle = securityStyle; }

const SecurityDetails* getSecurityDetails() const { return &m_securityDetails; }

- void setSecurityDetails(const String& protocol, const String& keyExchange, const String& cipher, const String& mac, int certId, size_t numUnknownScts, size_t numInvalidScts, size_t numValidScts, const SignedCertificateTimestampList& sctList);

+ void setSecurityDetails(const String& protocol, const String& keyExchange, const String& cipher, const String& mac, int certId, const SignedCertificateTimestampList& sctList);

long long appCacheID() const { return m_appCacheID; }

void setAppCacheID(long long id) { m_appCacheID = id; }