Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Unified Diff: third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js

Issue 2208803002: Remove SCT counters from DevTools security panel (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js
diff --git a/third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js b/third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js
index ec7d69a2bf8955461fa7e9e3487c2fc27861faf6..24bf68ab3b9b6738ee320d533de99f1c7c213917 100644
--- a/third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js
+++ b/third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js
@@ -802,7 +802,6 @@ WebInspector.SecurityOriginView = function(panel, origin, originState)
table.addRow(WebInspector.UIString("Valid From"), validFromString);
table.addRow(WebInspector.UIString("Valid Until"), validUntilString);
table.addRow(WebInspector.UIString("Issuer"), certificateDetails.issuer);
- table.addRow(WebInspector.UIString("SCTs"), this.sctSummary(originState.securityDetails.certificateValidationDetails));
table.addRow("", WebInspector.SecurityPanel.createCertificateViewerButton(WebInspector.UIString("Open full certificate details"), originState.securityDetails.certificateId));
if (!originState.securityDetails.signedCertificateTimestampList.length)
@@ -930,26 +929,6 @@ WebInspector.SecurityOriginView.prototype = {
this._originLockIcon.classList.add("security-property-" + newSecurityState);
},
- /**
- * @constructor
- * @param {?NetworkAgent.CertificateValidationDetails} details
- * @return {string}
- */
- sctSummary: function(details)
- {
- if (!details)
- return WebInspector.UIString("N/A");
-
- var sctTypeList = [];
- if (details.numValidScts)
- sctTypeList.push(WebInspector.UIString("%d valid SCT%s", details.numValidScts, (details.numValidScts > 1) ? "s" : ""));
- if (details.numInvalidScts)
- sctTypeList.push(WebInspector.UIString("%d invalid SCT%s", details.numInvalidScts, (details.numInvalidScts > 1) ? "s" : ""));
- if (details.numUnknownScts)
- sctTypeList.push(WebInspector.UIString("%d SCT%s from unknown logs", details.numUnknownScts, (details.numUnknownScts > 1) ? "s" : ""));
- return sctTypeList.length ? sctTypeList.join(", ") : WebInspector.UIString("0 SCTs");
- },
-
__proto__: WebInspector.VBox.prototype
}

Powered by Google App Engine
This is Rietveld 408576698