third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp - Issue 2208803002: Remove SCT counters from DevTools security panel

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp

Issue 2208803002: Remove SCT counters from DevTools security panel (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/inspector/security/sct-summary-expected.txt ('k') | third_party/WebKit/Source/core/inspector/browser_protocol.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp

diff --git a/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp b/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp

index 195ed54a88cfe64de03689944c5f5ec13b0064cd..eb417151582a35a50c789d8d303499fcb4d47b1a 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp

+++ b/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp

@@ -421,15 +421,6 @@ static std::unique_ptr<protocol::Network::Response> buildObjectForResourceRespon

const ResourceResponse::SecurityDetails* responseSecurityDetails = response.getSecurityDetails();

- int numUnknownSCTs = safeCast<int>(responseSecurityDetails->numUnknownSCTs);

- int numInvalidSCTs = safeCast<int>(responseSecurityDetails->numInvalidSCTs);

- int numValidSCTs = safeCast<int>(responseSecurityDetails->numValidSCTs);

- std::unique_ptr<protocol::Network::CertificateValidationDetails> certificateValidationDetails = protocol::Network::CertificateValidationDetails::create()

- .setNumUnknownScts(numUnknownSCTs)

- .setNumInvalidScts(numInvalidSCTs)

- .setNumValidScts(numValidSCTs).build();

std::unique_ptr<protocol::Array<protocol::Network::SignedCertificateTimestamp>> signedCertificateTimestampList = protocol::Array<protocol::Network::SignedCertificateTimestamp>::create();

for (auto const& sct : responseSecurityDetails->sctList) {

std::unique_ptr<protocol::Network::SignedCertificateTimestamp> signedCertificateTimestamp = protocol::Network::SignedCertificateTimestamp::create()

@@ -452,7 +443,6 @@ static std::unique_ptr<protocol::Network::Response> buildObjectForResourceRespon

.setCertificateId(responseSecurityDetails->certID)

.setSignedCertificateTimestampList(std::move(signedCertificateTimestampList))

.build();

- securityDetails->setCertificateValidationDetails(std::move(certificateValidationDetails));

if (responseSecurityDetails->mac.length() > 0)

securityDetails->setMac(responseSecurityDetails->mac);