Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 2208773002: Remove a couple uses of LabelButton::SetFontList (Closed)

Created:
4 years, 4 months ago by Evan Stade
Modified:
4 years, 4 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, oshima+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove a couple uses of LabelButton::SetFontList other uses are still blocked on removal of pre-MD codepaths or other code updates. BUG=633986 Committed: https://crrev.com/3cd12bc7b5094336d2ab5b0a4e307225a458a9ad Cr-Commit-Position: refs/heads/master@{#409786}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -7 lines) Patch
M chrome/browser/chromeos/profiles/multiprofiles_intro_dialog.cc View 1 chunk +1 line, -3 lines 0 comments Download
M ui/views/touchui/touch_selection_menu_runner_views.cc View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
Evan Stade
4 years, 4 months ago (2016-08-03 16:17:43 UTC) #4
sky
LGTM
4 years, 4 months ago (2016-08-03 17:09:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2208773002/1
4 years, 4 months ago (2016-08-03 18:01:37 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/203505)
4 years, 4 months ago (2016-08-03 19:51:16 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2208773002/1
4 years, 4 months ago (2016-08-04 13:47:32 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-04 15:09:05 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-08-04 15:10:47 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3cd12bc7b5094336d2ab5b0a4e307225a458a9ad
Cr-Commit-Position: refs/heads/master@{#409786}

Powered by Google App Engine
This is Rietveld 408576698