Initial implementation of dedicated FixedArray processing.

Initial implementation of dedicated FixedArray processing.

FixedArrays could be shown differently based on their subtypes.

Committed: https://crrev.com/32148868559979c8869a1f129129c6e94987e90b
Cr-Commit-Position: refs/heads/master@{#38351}

[alph, 2016-08-03 16:01:51]

alph@chromium.org changed reviewers:
+ ulan@chromium.org

[alph, 2016-08-03 16:01:57]

The CQ bit was checked by alph@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-03 16:02:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-03 16:21:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-03 16:21:34]

Dry run: This issue passed the CQ dry run.

[ulan, 2016-08-04 08:54:20]

lgtm

https://codereview.chromium.org/2208753002/diff/1/src/profiler/heap-snapshot-...
File src/profiler/heap-snapshot-generator.cc (right):

https://codereview.chromium.org/2208753002/diff/1/src/profiler/heap-snapshot-...
src/profiler/heap-snapshot-generator.cc:2146: array_types_[array] = type;
Maybe add a check that array is not tagged yet or if it is tagged than the tags
match.

[alph, 2016-08-04 18:28:27]

https://codereview.chromium.org/2208753002/diff/1/src/profiler/heap-snapshot-...
File src/profiler/heap-snapshot-generator.cc (right):

https://codereview.chromium.org/2208753002/diff/1/src/profiler/heap-snapshot-...
src/profiler/heap-snapshot-generator.cc:2146: array_types_[array] = type;
On 2016/08/04 08:54:20, ulan wrote:
> Maybe add a check that array is not tagged yet or if it is tagged than the
tags
> match.

Good idea. Done.

[alph, 2016-08-04 18:30:56]

The CQ bit was checked by alph@chromium.org

[alph, 2016-08-04 18:30:57]

The patchset sent to the CQ was uploaded after l-g-t-m from ulan@chromium.org
Link to the patchset: https://codereview.chromium.org/2208753002/#ps20001
(title: "adding a DCHECK")

[commit-bot: I haz the power, 2016-08-04 18:31:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-04 21:02:26]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-04 21:05:46]

Description was changed from

==========
Initial implementation of dedicated FixedArray processing.

FixedArrays could be shown differently based on their subtypes.
==========

to

==========
Initial implementation of dedicated FixedArray processing.

FixedArrays could be shown differently based on their subtypes.

Committed: https://crrev.com/32148868559979c8869a1f129129c6e94987e90b
Cr-Commit-Position: refs/heads/master@{#38351}
==========

[commit-bot: I haz the power, 2016-08-04 21:05:47]

Patchset 2 (id:??) landed as
https://crrev.com/32148868559979c8869a1f129129c6e94987e90b
Cr-Commit-Position: refs/heads/master@{#38351}