SkPDF: fewer GYP_DEFINES

SkPDF: fewer GYP_DEFINES

also: hack a unit test

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2208743003

Committed: https://skia.googlesource.com/skia/+/18e0cbc52a7a145cd6d915759ef9d611808960aa

[hal.canary, 2016-08-03 18:23:40]

Description was changed from

==========
SkPDF: fewer GYP_DEFINES

BUG=skia:
==========

to

==========
SkPDF: fewer GYP_DEFINES

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2208743003
==========

[hal.canary, 2016-08-03 18:23:53]

The CQ bit was checked by halcanary@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-03 18:23:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hal.canary, 2016-08-03 18:33:00]

halcanary@google.com changed reviewers:
+ mtklein@google.com

[hal.canary, 2016-08-03 18:33:01]

as discussed.

Also, I've moved over to GN on my linux box.

[hal.canary, 2016-08-03 18:33:42]

Description was changed from

==========
SkPDF: fewer GYP_DEFINES

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2208743003
==========

to

==========
SkPDF: fewer GYP_DEFINES

also: hack a unit test

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2208743003
==========

[commit-bot: I haz the power, 2016-08-03 18:44:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-03 18:44:56]

Dry run: This issue passed the CQ dry run.

[mtklein, 2016-08-03 19:28:46]

https://codereview.chromium.org/2208743003/diff/1/tests/PDFPrimitivesTest.cpp
File tests/PDFPrimitivesTest.cpp (right):

https://codereview.chromium.org/2208743003/diff/1/tests/PDFPrimitivesTest.cpp...
tests/PDFPrimitivesTest.cpp:117: #ifndef SK_PDF_LESS_COMPRESSION
?  Did this just also not work previously?

[hal.canary, 2016-08-03 21:16:07]

On 2016/08/03 19:28:46, mtklein wrote:
> https://codereview.chromium.org/2208743003/diff/1/tests/PDFPrimitivesTest.cpp
> File tests/PDFPrimitivesTest.cpp (right):
> 
>
https://codereview.chromium.org/2208743003/diff/1/tests/PDFPrimitivesTest.cpp...
> tests/PDFPrimitivesTest.cpp:117: #ifndef SK_PDF_LESS_COMPRESSION
> ?  Did this just also not work previously?

it did not.  I kept setting and un-setting my GYP_DEFINES depending on what I
was doing.

[mtklein, 2016-08-03 21:16:34]

lgtm

[hal.canary, 2016-08-03 21:16:52]

The CQ bit was checked by halcanary@google.com

[commit-bot: I haz the power, 2016-08-03 21:16:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-03 21:17:55]

Description was changed from

==========
SkPDF: fewer GYP_DEFINES

also: hack a unit test

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2208743003
==========

to

==========
SkPDF: fewer GYP_DEFINES

also: hack a unit test

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2208743003

Committed:
https://skia.googlesource.com/skia/+/18e0cbc52a7a145cd6d915759ef9d611808960aa
==========

[commit-bot: I haz the power, 2016-08-03 21:17:56]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/18e0cbc52a7a145cd6d915759ef9d611808960aa