Revert of cc: Make LayerTreeTests use a DelegatingRenderer and Display.

Revert of cc: Make LayerTreeTests use a DelegatingRenderer and Display. (patchset #6 id:120001 of https://codereview.chromium.org/2193293004/ )

Reason for revert:
Bisect identified that this patch broke cc_perftests on Linux and Android perf bots (crbug.com/634013).

Original issue's description:
> cc: Make LayerTreeTests use a DelegatingRenderer and Display.
>
> Wherein we rewrite a few thousand cc unit_tests to not use a
> DirectRenderer in LayerTreeHostImpl so that we can remove that
> possibility from the codebase.
>
> Currently some LayerTreeTests use a DirectRenderer in the
> LayerTreeHostImpl, which is the last case of this occuring. Instead
> give all LayerTreeTests a TestDelegatingOutputSurface (which means
> a DelegatingRenderer in LayerTreeHostImpl). TestDelegatingOutputSurface
> delegates drawing to a DirectRenderer via Display, which matches how
> things "really work" now.
>
> This means SwapBuffers hooks become async from operations on
> LayerTreeHostImpl, so we introduce 3 new hooks for tests:
> - DisplayReceivedCompositorFrameOnThread.
> - DisplayWillDrawAndSwapOnThread.
> - DisplayDidDrawAndSwapOnThread.
> None of these receive a LayerTreeHostImpl* since they are async
> from it and so using its state from the hook would be racey. These
> hooks come from the TestDelegatingOutputSurface instead of from the
> LayerTreeHostImpl.
>
> LayerTreeTest gets two methods that can be overridden to control the
> output surface:
> - CreateDelegatingOutputSurface makes a TestDelegatingOutputSurface
> so tests can control the arguments passed to its constructor, or the
> ContextProviders given to it.
> - CreateDisplayOutputSurface makes an OutputSurface subclass that
> will be owned by the Display and used by the DirectRenderer. This
> allows tests to control which ContextProvider it uses, and what
> subclass of OutputSurface to use, to allow mocking out things as
> desired.
>
> R=enne
> BUG=606056
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
>
> Committed: https://crrev.com/cae1058e62b7960796709512c4e1e650b6389c0f
> Cr-Commit-Position: refs/heads/master@{#409270}

TBR=enne@chromium.org,boliu@chromium.org,fsamuel@chromium.org,piman@chromium.org,danakj@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=606056
Committed: https://crrev.com/8ee20259fc28430498df2b22cb4a506d215d26dd
Cr-Commit-Position: refs/heads/master@{#409757}

[petrcermak, 2016-08-04 09:33:14]

The CQ bit was checked by petrcermak@chromium.org

[petrcermak, 2016-08-04 09:33:15]

Created Revert of cc: Make LayerTreeTests use a DelegatingRenderer and Display.

[commit-bot: I haz the power, 2016-08-04 09:33:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-04 10:36:38]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-04 10:37:54]

Description was changed from

==========
Revert of cc: Make LayerTreeTests use a DelegatingRenderer and Display.
(patchset #6 id:120001 of https://codereview.chromium.org/2193293004/ )

Reason for revert:
Bisect identified that this patch broke cc_perftests on Linux and Android perf
bots (crbug.com/634013).

Original issue's description:
> cc: Make LayerTreeTests use a DelegatingRenderer and Display.
> 
> Wherein we rewrite a few thousand cc unit_tests to not use a
> DirectRenderer in LayerTreeHostImpl so that we can remove that
> possibility from the codebase.
> 
> Currently some LayerTreeTests use a DirectRenderer in the
> LayerTreeHostImpl, which is the last case of this occuring. Instead
> give all LayerTreeTests a TestDelegatingOutputSurface (which means
> a DelegatingRenderer in LayerTreeHostImpl). TestDelegatingOutputSurface
> delegates drawing to a DirectRenderer via Display, which matches how
> things "really work" now.
> 
> This means SwapBuffers hooks become async from operations on
> LayerTreeHostImpl, so we introduce 3 new hooks for tests:
> - DisplayReceivedCompositorFrameOnThread.
> - DisplayWillDrawAndSwapOnThread.
> - DisplayDidDrawAndSwapOnThread.
> None of these receive a LayerTreeHostImpl* since they are async
> from it and so using its state from the hook would be racey. These
> hooks come from the TestDelegatingOutputSurface instead of from the
> LayerTreeHostImpl.
> 
> LayerTreeTest gets two methods that can be overridden to control the
> output surface:
> - CreateDelegatingOutputSurface makes a TestDelegatingOutputSurface
> so tests can control the arguments passed to its constructor, or the
> ContextProviders given to it.
> - CreateDisplayOutputSurface makes an OutputSurface subclass that
> will be owned by the Display and used by the DirectRenderer. This
> allows tests to control which ContextProvider it uses, and what
> subclass of OutputSurface to use, to allow mocking out things as
> desired.
> 
> R=enne
> BUG=606056
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
> 
> Committed: https://crrev.com/cae1058e62b7960796709512c4e1e650b6389c0f
> Cr-Commit-Position: refs/heads/master@{#409270}

TBR=enne@chromium.org,boliu@chromium.org,fsamuel@chromium.org,piman@chromium....
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=606056
==========

to

==========
Revert of cc: Make LayerTreeTests use a DelegatingRenderer and Display.
(patchset #6 id:120001 of https://codereview.chromium.org/2193293004/ )

Reason for revert:
Bisect identified that this patch broke cc_perftests on Linux and Android perf
bots (crbug.com/634013).

Original issue's description:
> cc: Make LayerTreeTests use a DelegatingRenderer and Display.
>
> Wherein we rewrite a few thousand cc unit_tests to not use a
> DirectRenderer in LayerTreeHostImpl so that we can remove that
> possibility from the codebase.
>
> Currently some LayerTreeTests use a DirectRenderer in the
> LayerTreeHostImpl, which is the last case of this occuring. Instead
> give all LayerTreeTests a TestDelegatingOutputSurface (which means
> a DelegatingRenderer in LayerTreeHostImpl). TestDelegatingOutputSurface
> delegates drawing to a DirectRenderer via Display, which matches how
> things "really work" now.
>
> This means SwapBuffers hooks become async from operations on
> LayerTreeHostImpl, so we introduce 3 new hooks for tests:
> - DisplayReceivedCompositorFrameOnThread.
> - DisplayWillDrawAndSwapOnThread.
> - DisplayDidDrawAndSwapOnThread.
> None of these receive a LayerTreeHostImpl* since they are async
> from it and so using its state from the hook would be racey. These
> hooks come from the TestDelegatingOutputSurface instead of from the
> LayerTreeHostImpl.
>
> LayerTreeTest gets two methods that can be overridden to control the
> output surface:
> - CreateDelegatingOutputSurface makes a TestDelegatingOutputSurface
> so tests can control the arguments passed to its constructor, or the
> ContextProviders given to it.
> - CreateDisplayOutputSurface makes an OutputSurface subclass that
> will be owned by the Display and used by the DirectRenderer. This
> allows tests to control which ContextProvider it uses, and what
> subclass of OutputSurface to use, to allow mocking out things as
> desired.
>
> R=enne
> BUG=606056
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
>
> Committed: https://crrev.com/cae1058e62b7960796709512c4e1e650b6389c0f
> Cr-Commit-Position: refs/heads/master@{#409270}

TBR=enne@chromium.org,boliu@chromium.org,fsamuel@chromium.org,piman@chromium....
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=606056

Committed: https://crrev.com/8ee20259fc28430498df2b22cb4a506d215d26dd
Cr-Commit-Position: refs/heads/master@{#409757}
==========

[commit-bot: I haz the power, 2016-08-04 10:37:56]

Patchset 1 (id:??) landed as
https://crrev.com/8ee20259fc28430498df2b22cb4a506d215d26dd
Cr-Commit-Position: refs/heads/master@{#409757}