Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1287)

Issue 2208603005: [interpreter] Fix profiler when hitting OSR frame. (Closed)

Created:
4 years, 4 months ago by Michael Starzinger
Modified:
4 years, 4 months ago
Reviewers:
rmcilroy
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] Fix profiler when hitting OSR frame. This fixes the runtime profiler to no longer assume that seeing an optimized frame on the stack implies the underlying function is not being interpreted when entered normally. This no longer holds with code generated for OSR directly from bytecode (not installed on function). R=rmcilroy@chromium.org TEST=mjsunit/regress/regress-crbug-632800 BUG=chromium:632800 Committed: https://crrev.com/f00b42ae31da497b3b25fc9012cdd8897e0463c4 Cr-Commit-Position: refs/heads/master@{#38360}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -23 lines) Patch
M src/runtime-profiler.h View 1 chunk +2 lines, -5 lines 0 comments Download
M src/runtime-profiler.cc View 5 chunks +17 lines, -14 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-632800.js View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
Michael Starzinger
4 years, 4 months ago (2016-08-04 16:18:29 UTC) #6
rmcilroy
Lgtm, thanks!
4 years, 4 months ago (2016-08-04 17:38:35 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2208603005/1
4 years, 4 months ago (2016-08-05 08:43:50 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-05 08:45:31 UTC) #13
commit-bot: I haz the power
4 years, 4 months ago (2016-08-05 08:47:56 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f00b42ae31da497b3b25fc9012cdd8897e0463c4
Cr-Commit-Position: refs/heads/master@{#38360}

Powered by Google App Engine
This is Rietveld 408576698