Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 2208593002: [Mac][Material Design] Increase space between home button and Omnibox. (Closed)

Created:
4 years, 4 months ago by shrike
Modified:
4 years, 4 months ago
Reviewers:
tapted
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac][Material Design] Increase space between home button and Omnibox. When the home button is visible in Material Design it's too close to the Omnibox. This cl adds the proper spacing. R=tapted@chromium.org BUG=625190 Committed: https://crrev.com/b1aa063a58ac043b5f4a8c6d7e9115e6ec2b8f05 Cr-Commit-Position: refs/heads/master@{#409553}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm View 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
shrike
PTAL
4 years, 4 months ago (2016-08-03 00:01:04 UTC) #1
tapted
lgtm
4 years, 4 months ago (2016-08-03 00:50:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2208593002/1
4 years, 4 months ago (2016-08-03 16:33:24 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-03 17:20:01 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-08-03 17:21:13 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b1aa063a58ac043b5f4a8c6d7e9115e6ec2b8f05
Cr-Commit-Position: refs/heads/master@{#409553}

Powered by Google App Engine
This is Rietveld 408576698