Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6230)

Unified Diff: chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc

Issue 2208583006: UMA for pin unlock success/failure. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr
Patch Set: Fixed patch set 9 errors. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h ('k') | chromeos/login/auth/user_context.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc
diff --git a/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc b/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc
index 10bfe44c76e23f9319811f26439e9e9f946bcc2c..fd64a50ef38211f66f0b58f53bf3bd3e071bf7c7 100644
--- a/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc
+++ b/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc
@@ -1059,14 +1059,21 @@ void SigninScreenHandler::UpdateAddButtonStatus() {
}
void SigninScreenHandler::HandleAuthenticateUser(const AccountId& account_id,
- const std::string& password) {
+ const std::string& password,
+ bool authenticated_by_pin) {
if (!delegate_)
return;
DCHECK_EQ(account_id.GetUserEmail(),
gaia::SanitizeEmail(account_id.GetUserEmail()));
+ chromeos::PinStorage* pin_storage =
+ chromeos::PinStorageFactory::GetForAccountId(account_id);
+ // If pin storage is unavailable, authenticated by PIN must be false.
+ DCHECK(!pin_storage || pin_storage->IsPinAuthenticationAvailable() ||
+ !authenticated_by_pin);
UserContext user_context(account_id);
user_context.SetKey(Key(password));
+ user_context.SetIsUsingPin(authenticated_by_pin);
delegate_->Login(user_context, SigninSpecifics());
HidePinKeyboardIfNeeded(account_id);
« no previous file with comments | « chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h ('k') | chromeos/login/auth/user_context.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698