UMA for pin unlock success/failure.

chrome/browser/chromeos/login/lock/screen_locker.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROMEOS_LOGIN_LOCK_SCREEN_LOCKER_H_
 #define CHROME_BROWSER_CHROMEOS_LOGIN_LOCK_SCREEN_LOCKER_H_
 
 #include <memory>
 #include <string>
 
@@ skipping 31 matching lines @@
 class ScreenLockerTester;
 class ScreenLockerViewsTester;
 class WebUIScreenLockerTester;
 }  // namespace test
 
 // ScreenLocker creates a ScreenLockerDelegate which will display the lock UI.
 // As well, it takes care of authenticating the user and managing a global
 // instance of itself which will be deleted when the system is unlocked.
 class ScreenLocker : public AuthStatusConsumer {
  public:
+  enum UnlockSuccess {

[jdufault, 2016/08/16 17:55:02]

Is it possible to make these enums private?

[sammiequon, 2016/08/16 19:22:11]

Done.

+    AUTH_SUCCESS_PASSWORD = 0,
+    AUTH_SUCCESS_PIN,
+    AUTH_SUCCESS_COUNT
+  };
+
+  enum UnlockFailure {

[jdufault, 2016/08/16 17:55:02]

Do these need to be separate enums? Is it possible to just have

  enum UnlockType {
    AUTH_PASSWORD = 0,
    AUTH_PIN,
    AUTH_COUNT
  };

[sammiequon, 2016/08/16 19:22:11]

Done.

+    AUTH_FAILURE_PASSWORD = 0,
+    AUTH_FAILURE_PIN,
+    AUTH_FAILURE_COUNT
+  };
+
   explicit ScreenLocker(const user_manager::UserList& users);
 
   // Returns the default instance if it has been created.
   static ScreenLocker* default_screen_locker() {
     return screen_locker_;
   }
 
   bool locked() const { return locked_; }
 
   // Initialize and show the screen locker.
@@ skipping 98 matching lines @@
 
   // Used to authenticate the user to unlock.
   scoped_refptr<Authenticator> authenticator_;
 
   // Used to authenticate the user to unlock supervised users.
   scoped_refptr<ExtendedAuthenticator> extended_authenticator_;
 
   // True if the screen is locked, or false otherwise.  This changes
   // from false to true, but will never change from true to
   // false. Instead, ScreenLocker object gets deleted when unlocked.
-  bool locked_;
+  bool locked_ = false;
 
   // Reference to the single instance of the screen locker object.
   // This is used to make sure there is only one screen locker instance.
   static ScreenLocker* screen_locker_;
 
   // The time when the screen locker object is created.
   base::Time start_time_;
   // The time when the authentication is started.
   base::Time authentication_start_time_;
 
   // Delegate to forward all login status events to.
   // Tests can use this to receive login status events.
   AuthStatusConsumer* auth_status_consumer_;
 
   // Number of bad login attempts in a row.
-  int incorrect_passwords_count_;
+  int incorrect_passwords_count_ = 0;
+
+  // Whether the last password entered was a pin or not.
+  bool is_pin_attempt_ = false;
 
   // Copy of parameters passed to last call of OnLoginSuccess for usage in
   // UnlockOnLoginSuccess().
   std::unique_ptr<AuthenticationParametersCapture> authentication_capture_;
 
   // Provider for button icon set by the screenlockPrivate API.
   std::unique_ptr<ScreenlockIconProvider> screenlock_icon_provider_;
 
   scoped_refptr<input_method::InputMethodManager::State> saved_ime_state_;
 
   base::WeakPtrFactory<ScreenLocker> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(ScreenLocker);
 };
 
 }  // namespace chromeos
 
 #endif  // CHROME_BROWSER_CHROMEOS_LOGIN_LOCK_SCREEN_LOCKER_H_