Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Side by Side Diff: content/browser/renderer_host/render_widget_host_view_aura.h

Issue 2208583005: Request to start/stop calculating composition info from RenderWidget when it is active/inactive. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixing a Crash due to Pure Virtual Call Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_AURA_H_ 5 #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_AURA_H_
6 #define CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_AURA_H_ 6 #define CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_AURA_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 669 matching lines...) Expand 10 before | Expand all | Expand 10 after
680 // the current view has focus. Defaults to false. 680 // the current view has focus. Defaults to false.
681 bool set_focus_on_mouse_down_or_key_event_; 681 bool set_focus_on_mouse_down_or_key_event_;
682 682
683 float device_scale_factor_; 683 float device_scale_factor_;
684 684
685 // Allows tests to send gesture events for testing without first sending a 685 // Allows tests to send gesture events for testing without first sending a
686 // corresponding touch sequence, as would be required by 686 // corresponding touch sequence, as would be required by
687 // RenderWidgetHostInputEventRouter. 687 // RenderWidgetHostInputEventRouter.
688 bool disable_input_event_router_for_testing_; 688 bool disable_input_event_router_for_testing_;
689 689
690 // The last RenderWidgetHost which had an active text input state.
691 RenderWidgetHostImpl* last_active_widget_;
Charlie Reis 2016/08/03 22:16:23 What guarantees we won't get a use-after-free here
EhsanK 2016/08/04 18:57:58 Actually, there was a way to crash this. Good catc
692
690 base::WeakPtrFactory<RenderWidgetHostViewAura> weak_ptr_factory_; 693 base::WeakPtrFactory<RenderWidgetHostViewAura> weak_ptr_factory_;
691 694
692 DISALLOW_COPY_AND_ASSIGN(RenderWidgetHostViewAura); 695 DISALLOW_COPY_AND_ASSIGN(RenderWidgetHostViewAura);
693 }; 696 };
694 697
695 } // namespace content 698 } // namespace content
696 699
697 #endif // CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_AURA_H_ 700 #endif // CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_AURA_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698