Request to start/stop calculating composition info from RenderWidget when it is active/inactive.

chrome/browser/renderer_host/site_per_process_text_input_browsertest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <vector>
 
 #include "base/command_line.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
@@ skipping 209 matching lines @@
       content::RenderWidgetHostView* expected_view)
       : TextInputManagerObserverBase(web_contents),
         expected_view_(expected_view) {
     tester()->SetOnImeCompositionRangeChangedCallback(
         base::Bind(&ViewCompositionRangeChangedObserver::VerifyChange,
                    base::Unretained(this)));
   }
 
  private:
   void VerifyChange() {
+    LOG(INFO) << "View: " << tester()->GetUpdatedView();

[Charlie Reis, 2016/08/03 22:16:23]

Did you mean to leave these in?

[EhsanK, 2016/08/04 18:57:58]

No sorry. Removed. Thanks!

     if (expected_view_ == tester()->GetUpdatedView())
       OnSuccess();
   }
 
   const content::RenderWidgetHostView* const expected_view_;
 
   DISALLOW_COPY_AND_ASSIGN(ViewCompositionRangeChangedObserver);
 };
 
 // This class observes the |expected_view| for a change in the text selection
 // that has a selection length of |expected_length|.
 class ViewTextSelectionObserver : public TextInputManagerObserverBase {
  public:
   ViewTextSelectionObserver(content::WebContents* web_contents,
                             content::RenderWidgetHostView* expected_view,
                             size_t expected_selection_length)
       : TextInputManagerObserverBase(web_contents),
         expected_view_(expected_view),
         expected_selection_length_(expected_selection_length) {
     tester()->SetOnTextSelectionChangedCallback(base::Bind(
         &ViewTextSelectionObserver::VerifyChange, base::Unretained(this)));
   }
 
  private:
   void VerifyChange() {
     if (expected_view_ == tester()->GetUpdatedView()) {
       size_t selection_length;
       if (tester()->GetCurrentTextSelectionLength(&selection_length) &&
-          expected_selection_length_ == selection_length)
+          expected_selection_length_ == selection_length) {
+        LOG(INFO) << "Observed length:" << selection_length;
         OnSuccess();
+      }
     }
   }
 
   const content::RenderWidgetHostView* const expected_view_;
   const size_t expected_selection_length_;
 
   DISALLOW_COPY_AND_ASSIGN(ViewTextSelectionObserver);
 };
 
 // This class monitors all the changes in TextInputState and keeps a record of
@@ skipping 337 matching lines @@
     send_tab_insert_text_wait_for_bounds_change(view);
 }
 
 // This test creates a page with multiple child frames and adds an <input> to
 // each frame. Then, sequentially, each <input> is focused by sending a tab key.
 // Then, after |TextInputState.type| for a view is changed to text, the test
 // sends a set composition IPC to the active widget and waits until the widget
 // updates its composition range.
 IN_PROC_BROWSER_TEST_F(SitePerProcessTextInputManagerTest,
                        TrackCompositionRangeForAllFrames) {
-  // TODO(ekaramd): After IME methods are implemented for WebFrameWidgetImpl,
-  // change the page so that it contains child frames as well
-  // (crbug.com/626746).
-  CreateIframePage("a()");
-  std::vector<content::RenderFrameHost*> frames{GetFrame(IndexVector{})};
+  CreateIframePage("a(b,c(a,b),d)");
+  std::vector<content::RenderFrameHost*> frames{
+      GetFrame(IndexVector{}),     GetFrame(IndexVector{0}),
+      GetFrame(IndexVector{1}),    GetFrame(IndexVector{1, 0}),
+      GetFrame(IndexVector{1, 1}), GetFrame(IndexVector{2})};
   std::vector<content::RenderWidgetHostView*> views;
   for (auto* frame : frames)
     views.push_back(frame->GetView());
   for (size_t i = 0; i < frames.size(); ++i)
-    AddInputFieldToFrame(frames[i], "text", "", true);
+    AddInputFieldToFrame(frames[i], "text", "text", true);
 
   content::WebContents* web_contents = active_contents();
 
-  auto send_tab_set_composition_wait_for_bounds_change =
-      [&web_contents](content::RenderWidgetHostView* view) {
-        ViewTextInputTypeObserver type_observer(web_contents, view,
-                                                ui::TEXT_INPUT_TYPE_TEXT);
-        SimulateKeyPress(web_contents, ui::DomKey::TAB, ui::DomCode::TAB,
-                         ui::VKEY_TAB, false, false, false, false);
-        type_observer.Wait();
-        ViewCompositionRangeChangedObserver range_observer(web_contents, view);
-        content::SetCompositionForRenderWidgetHost(
-            view->GetRenderWidgetHost(), base::ASCIIToUTF16("text"),
-            {ui::CompositionUnderline()}, gfx::Range::InvalidRange(), 0, 0);
-        range_observer.Wait();
-      };
+  auto send_tab_set_composition_wait_for_bounds_change = [&web_contents](
+      content::RenderWidgetHostView* view) {
+    ViewTextInputTypeObserver type_observer(web_contents, view,
+                                            ui::TEXT_INPUT_TYPE_TEXT);
+    SimulateKeyPress(web_contents, ui::DomKey::TAB, ui::DomCode::TAB,
+                     ui::VKEY_TAB, false, false, false, false);
+    type_observer.Wait();
+    ViewCompositionRangeChangedObserver range_observer(web_contents, view);
+    EXPECT_TRUE(content::RequestCompositionInfoFromActiveWidget(web_contents));
+    range_observer.Wait();
+    LOG(INFO) << "Wait for view is over: " << view;

[Charlie Reis, 2016/08/03 22:16:23]

Should probably remove this as well.

[EhsanK, 2016/08/04 18:57:58]

Done.

+  };
 
   for (auto* view : views)
     send_tab_set_composition_wait_for_bounds_change(view);
 }
 
 // This test creates a page with multiple child frames and adds an <input> to
 // each frame. Then, sequentially, each <input> is focused by sending a tab key.
 // After focusing each input, the whole text is automatically selected and a
 // ViewHostMsg_SelectionChanged IPC sent back to the browser. This test verifies
 // that the browser tracks the text selection from all frames.
@@ skipping 188 matching lines @@
 
   // Set |TextInputState.show_ime_if_needed|. Expect IME.
   sender.SetShowImeIfNeeded(true);
   EXPECT_TRUE(send_and_check_show_ime());
 
   // Set |TextInputState.type| to ui::TEXT_INPUT_TYPE_NONE. Expect no IME.
   sender.SetType(ui::TEXT_INPUT_TYPE_NONE);
   EXPECT_FALSE(send_and_check_show_ime());
 }
 #endif  // USE_AURA