Fix cr-user-autocomplete for Chrome.

Fix cr-user-autocomplete for Chrome.

We need to use execCommand now, unfortunately that doesn't work in
Firefox which is sad and requires a nasty UA sniffing hack.

BUG=632932
Committed: https://chromium.googlesource.com/infra/infra/+/8c8fd5a600315e3193f78732c68b25a13efdb85d

[esprehn, 2016-08-03 05:27:23]

esprehn@chromium.org changed reviewers:
+ andybons@chromium.org, jrobbins@chromium.org

[jrobbins, 2016-08-03 15:47:36]

lgtm

[Bons, 2016-08-03 15:48:02]

The CQ bit was checked by andybons@chromium.org

[Bons, 2016-08-03 15:48:03]

lgtm

[commit-bot: I haz the power, 2016-08-03 15:48:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bons, 2016-08-03 15:49:42]

https://codereview.chromium.org/2208573003/diff/20001/appengine/chromium_riet...
File appengine/chromium_rietveld/new_static/components/cr-user-autocomplete.html
(right):

https://codereview.chromium.org/2208573003/diff/20001/appengine/chromium_riet...
appengine/chromium_rietveld/new_static/components/cr-user-autocomplete.html:171:
// Chrome and Safari can use execCommand.
FYI Polymer Rietveld doesn’t render in Safari (mobile or desktop) and hasn’t for
a pretty long time.

[PhistucK, 2016-08-03 15:51:19]

phistuck@gmail.com changed reviewers:
+ phistuck@gmail.com

[PhistucK, 2016-08-03 15:51:20]

https://codereview.chromium.org/2208573003/diff/20001/appengine/chromium_riet...
File appengine/chromium_rietveld/new_static/components/cr-user-autocomplete.html
(left):

https://codereview.chromium.org/2208573003/diff/20001/appengine/chromium_riet...
appengine/chromium_rietveld/new_static/components/cr-user-autocomplete.html:167:
})));
Perhaps this is a Blink issue. Have you filed one? :)

https://codereview.chromium.org/2208573003/diff/20001/appengine/chromium_riet...
File appengine/chromium_rietveld/new_static/components/cr-user-autocomplete.html
(right):

https://codereview.chromium.org/2208573003/diff/20001/appengine/chromium_riet...
appengine/chromium_rietveld/new_static/components/cr-user-autocomplete.html:161:
if (navigator.userAgent.contains("Firefox")) {
Yes, no. :P

https://codereview.chromium.org/2208573003/diff/20001/appengine/chromium_riet...
appengine/chromium_rietveld/new_static/components/cr-user-autocomplete.html:172:
document.execCommand("InsertText", false, value);
Yes, well, this is non-standard. I advise against it.

[commit-bot: I haz the power, 2016-08-03 16:01:52]

Description was changed from

==========
Fix cr-user-autocomplete for Chrome.

We need to use execCommand now, unfortunately that doesn't work in
Firefox which is sad and requires a nasty UA sniffing hack.

BUG=632932
==========

to

==========
Fix cr-user-autocomplete for Chrome.

We need to use execCommand now, unfortunately that doesn't work in
Firefox which is sad and requires a nasty UA sniffing hack.

BUG=632932

Committed:
https://chromium.googlesource.com/infra/infra/+/8c8fd5a600315e3193f78732c68b2...
==========

[commit-bot: I haz the power, 2016-08-03 16:01:53]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/infra/infra/+/8c8fd5a600315e3193f78732c68b2...

[esprehn, 2016-08-03 16:46:53]

https://codereview.chromium.org/2208573003/diff/20001/appengine/chromium_riet...
File appengine/chromium_rietveld/new_static/components/cr-user-autocomplete.html
(right):

https://codereview.chromium.org/2208573003/diff/20001/appengine/chromium_riet...
appengine/chromium_rietveld/new_static/components/cr-user-autocomplete.html:171:
// Chrome and Safari can use execCommand.
On 2016/08/03 at 15:49:42, Bons wrote:
> FYI Polymer Rietveld doesn’t render in Safari (mobile or desktop) and hasn’t
for a pretty long time.

It works for me in WebKit nightly , where do you see it not working?

https://codereview.chromium.org/2208573003/diff/20001/appengine/chromium_riet...
appengine/chromium_rietveld/new_static/components/cr-user-autocomplete.html:172:
document.execCommand("InsertText", false, value);
On 2016/08/03 at 15:51:20, PhistucK wrote:
> Yes, well, this is non-standard. I advise against it.

Given that there's no workaround we're going to do this. :)