Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2208563002: Revert of [tools/perf] Disable testBasicTraceRecording on Mac (Closed)

Created:
4 years, 4 months ago by nednguyen
Modified:
4 years, 4 months ago
Reviewers:
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [tools/perf] Disable testBasicTraceRecording on Mac (patchset #1 id:1 of https://codereview.chromium.org/2206433003/ ) Reason for revert: This test is not the cause of telemetry_perf_unittest flakiness. Original issue's description: > [tools/perf] Disable testBasicTraceRecording on Mac > > BUG=633579 > TBR=nduca@chromium.org, gab@chromium.org > > Committed: https://crrev.com/ff4ed9af692f5d0d79654a81adf4fd82b500a107 > Cr-Commit-Position: refs/heads/master@{#409195} TBR= # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=633579 Committed: https://crrev.com/539e1fedbe28dc6262cb877138e58ec00b958319 Cr-Commit-Position: refs/heads/master@{#409373}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M tools/perf/core/about_tracing_integration_test.py View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
nednguyen
Created Revert of [tools/perf] Disable testBasicTraceRecording on Mac
4 years, 4 months ago (2016-08-02 23:12:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2208563002/1
4 years, 4 months ago (2016-08-02 23:12:59 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-02 23:13:41 UTC) #4
commit-bot: I haz the power
4 years, 4 months ago (2016-08-02 23:17:03 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/539e1fedbe28dc6262cb877138e58ec00b958319
Cr-Commit-Position: refs/heads/master@{#409373}

Powered by Google App Engine
This is Rietveld 408576698