Simplify reload error reporting

runtime/vm/unit_test.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/unit_test.h"
 
 #include <stdio.h>
 
 #include "bin/builtin.h"
 #include "bin/dartutils.h"
@@ skipping 273 matching lines @@
   ASSERT(script_reload_key != kUnsetThreadLocalKey);
   ASSERT(OSThread::GetThreadLocal(script_reload_key) == 0);
   // Store the new script in TLS.
   OSThread::SetThreadLocal(script_reload_key, reinterpret_cast<uword>(script));
 }
 
 
 Dart_Handle TestCase::TriggerReload() {
   Isolate* isolate = Isolate::Current();
   JSONStream js;
-
+  bool success = false;
   {
     TransitionNativeToVM transition(Thread::Current());
-    isolate->ReloadSources(&js,
-                           false,  // force_reload
-                           true);  // dont_delete_reload_context
+    success = isolate->ReloadSources(&js,
+                                     false,  // force_reload
+                                     true);  // dont_delete_reload_context
     fprintf(stderr, "RELOAD REPORT:\n%s\n", js.ToCString());

[rmacnak, 2016/08/03 19:55:25]

OS::PrintErr

[Cutch, 2016/08/03 21:17:19]

Acknowledged.

   }
 
-  return Dart_FinalizeLoading(false);
+  if (success) {
+    return Dart_FinalizeLoading(false);
+  } else {
+    return Dart_Null();

[rmacnak, 2016/08/03 19:55:25]

Shouldn't this return some kind of error?

[Cutch, 2016/08/03 21:17:19]

In the unit tests we keep the reload context alive and grab the error from it
explicitly.

+  }
 }
 
 
 Dart_Handle TestCase::GetReloadErrorOrRootLibrary() {
   Isolate* isolate = Isolate::Current();
 
   if (isolate->reload_context() != NULL &&
       isolate->reload_context()->reload_aborted()) {
     // Return a handle to the error.
     return Api::NewHandle(Thread::Current(),
@@ skipping 173 matching lines @@
   }
   // Copy the remainder of in to out.
   while (*in != '\0') {
     *out++ = *in++;
   }
   *out = '\0';
 }
 
 
 }  // namespace dart