Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2208533003: Get rid of library proto information for debugger libraries (Closed)

Created:
4 years, 4 months ago by bmilligan
Modified:
4 years, 4 months ago
Reviewers:
Jacob
CC:
dev-compiler+reviews_dartlang.org, Alan Knight, priscillalee
Base URL:
https://github.com/dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Get rid of library proto information for debugger libraries BUG= R=jacobr@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/db950878eded7ab400c71f4a7b0c9cfd66b06fd3

Patch Set 1 #

Total comments: 2

Patch Set 2 : Deletion of library name caching #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -17 lines) Patch
M lib/runtime/dart_library.js View 1 chunk +1 line, -0 lines 0 comments Download
M lib/runtime/dart_sdk.js View 1 1 chunk +5 lines, -9 lines 0 comments Download
M tool/input_sdk/private/debugger.dart View 1 1 chunk +2 lines, -7 lines 0 comments Download
M tool/sdk_expected_errors.txt View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
bmilligan
4 years, 4 months ago (2016-08-02 23:54:15 UTC) #2
Jacob
https://codereview.chromium.org/2208533003/diff/1/tool/input_sdk/private/debugger.dart File tool/input_sdk/private/debugger.dart (right): https://codereview.chromium.org/2208533003/diff/1/tool/input_sdk/private/debugger.dart#newcode517 tool/input_sdk/private/debugger.dart:517: var libraryNames = libraryName.split('/'); This seems broken. Should we ...
4 years, 4 months ago (2016-08-02 23:57:43 UTC) #3
bmilligan
https://codereview.chromium.org/2208533003/diff/1/tool/input_sdk/private/debugger.dart File tool/input_sdk/private/debugger.dart (right): https://codereview.chromium.org/2208533003/diff/1/tool/input_sdk/private/debugger.dart#newcode517 tool/input_sdk/private/debugger.dart:517: var libraryNames = libraryName.split('/'); On 2016/08/02 23:57:43, Jacob wrote: ...
4 years, 4 months ago (2016-08-03 00:03:56 UTC) #4
Jacob
lgtm
4 years, 4 months ago (2016-08-03 00:07:13 UTC) #5
bmilligan
4 years, 4 months ago (2016-08-03 00:08:37 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
db950878eded7ab400c71f4a7b0c9cfd66b06fd3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698