Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(902)

Issue 2208513002: [ash-md] Fixes the vertical offset for search in overview with ChromeVox (Closed)

Created:
4 years, 4 months ago by varkha
Modified:
4 years, 4 months ago
Reviewers:
tdanderson
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ash-md] Fixes the vertical offset for search in overview with ChromeVox BUG=631908 Committed: https://crrev.com/da81a26c1a9726d08b01db32a9f33b9d007d6cac Cr-Commit-Position: refs/heads/master@{#409423}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M ash/common/wm/overview/window_selector.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
varkha
tdanderson@, can you please take a look. Turns out this was a simple bug. Thanks!
4 years, 4 months ago (2016-08-02 21:39:34 UTC) #4
tdanderson
lgtm
4 years, 4 months ago (2016-08-02 21:40:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2208513002/1
4 years, 4 months ago (2016-08-03 01:42:30 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-03 01:48:24 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-03 01:50:37 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/da81a26c1a9726d08b01db32a9f33b9d007d6cac
Cr-Commit-Position: refs/heads/master@{#409423}

Powered by Google App Engine
This is Rietveld 408576698