Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 2208503004: Move embedder locator and convert context builder to use the new API (Closed)

Created:
4 years, 4 months ago by Brian Wilkerson
Modified:
4 years, 4 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Move embedder locator and convert context builder to use the new API R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/b888675b55f5978cccf2e9780a5cb4fe39cb729b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+153 lines, -106 lines) Patch
M pkg/analyzer/lib/source/embedder.dart View 2 chunks +2 lines, -71 lines 0 comments Download
M pkg/analyzer/lib/src/context/builder.dart View 4 chunks +99 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/context/context.dart View 3 chunks +3 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/dart/sdk/sdk.dart View 1 chunk +14 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 2 chunks +2 lines, -1 line 0 comments Download
M pkg/analyzer/test/generated/engine_test.dart View 3 chunks +7 lines, -7 lines 0 comments Download
M pkg/analyzer/test/source/embedder_test.dart View 3 chunks +1 line, -24 lines 0 comments Download
M pkg/analyzer/test/src/context/builder_test.dart View 3 chunks +25 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
Updates to analyzer_cli and analysis_server to follow, then I can deprecate the old API.
4 years, 4 months ago (2016-08-03 21:32:23 UTC) #2
scheglov
LGTM
4 years, 4 months ago (2016-08-03 21:34:57 UTC) #3
Brian Wilkerson
4 years, 4 months ago (2016-08-04 17:41:58 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b888675b55f5978cccf2e9780a5cb4fe39cb729b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698