Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2747)

Unified Diff: base/task_scheduler/scheduler_worker_pool_impl.cc

Issue 2208493002: TaskScheduler: No BACKGROUND threads when unsupported. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase + CR robliao #6 (nit) Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/task_scheduler/scheduler_worker_pool_impl.cc
diff --git a/base/task_scheduler/scheduler_worker_pool_impl.cc b/base/task_scheduler/scheduler_worker_pool_impl.cc
index b97ce8dd1981ab440058cc96a0fd8bfaa204d0ff..39a5e2eedc716aaebd3f3acf5b5cfbeaaaa5cd6e 100644
--- a/base/task_scheduler/scheduler_worker_pool_impl.cc
+++ b/base/task_scheduler/scheduler_worker_pool_impl.cc
@@ -253,8 +253,7 @@ std::unique_ptr<SchedulerWorkerPoolImpl> SchedulerWorkerPoolImpl::Create(
params.io_restriction(),
params.suggested_reclaim_time(),
task_tracker, delayed_task_manager));
- if (worker_pool->Initialize(params.thread_priority(),
- params.max_threads(),
+ if (worker_pool->Initialize(params.priority_hint(), params.max_threads(),
re_enqueue_sequence_callback)) {
return worker_pool;
}
@@ -569,7 +568,7 @@ SchedulerWorkerPoolImpl::SchedulerWorkerPoolImpl(
}
bool SchedulerWorkerPoolImpl::Initialize(
- ThreadPriority thread_priority,
+ ThreadPriority priority_hint,
size_t max_threads,
const ReEnqueueSequenceCallback& re_enqueue_sequence_callback) {
AutoSchedulerLock auto_lock(idle_workers_stack_lock_);
@@ -577,15 +576,12 @@ bool SchedulerWorkerPoolImpl::Initialize(
DCHECK(workers_.empty());
for (size_t i = 0; i < max_threads; ++i) {
- std::unique_ptr<SchedulerWorker> worker =
- SchedulerWorker::Create(
- thread_priority, WrapUnique(new SchedulerWorkerDelegateImpl(
- this, re_enqueue_sequence_callback,
- &shared_priority_queue_, static_cast<int>(i))),
- task_tracker_,
- i == 0
- ? SchedulerWorker::InitialState::ALIVE
- : SchedulerWorker::InitialState::DETACHED);
+ std::unique_ptr<SchedulerWorker> worker = SchedulerWorker::Create(
+ priority_hint, WrapUnique(new SchedulerWorkerDelegateImpl(
+ this, re_enqueue_sequence_callback,
+ &shared_priority_queue_, static_cast<int>(i))),
+ task_tracker_, i == 0 ? SchedulerWorker::InitialState::ALIVE
+ : SchedulerWorker::InitialState::DETACHED);
if (!worker)
break;
idle_workers_stack_.Push(worker.get());
« no previous file with comments | « base/task_scheduler/scheduler_worker_pool_impl.h ('k') | base/task_scheduler/scheduler_worker_pool_params.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698