Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 2208483003: Delay DOM mutation events in HTMLSelectElement::setOption(). (Closed)

Created:
4 years, 4 months ago by tkent
Modified:
4 years, 4 months ago
Reviewers:
kochi
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Delay DOM mutation events in HTMLSelectElement::setOption(). HTMLSelectElement::add() dispatches a DOM mutation event, and an event handler can change the OPTION element state. This CL fixes an assertion failure in optionSelectionStateChanged() by delaying DOM mutation events by EventQueueScope. BUG=633505 Committed: https://crrev.com/3d36d86ae85cb65f5b9e67a492cb5ee48e4ebd3b Cr-Commit-Position: refs/heads/master@{#409466}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -5 lines) Patch
A third_party/WebKit/LayoutTests/fast/forms/select/select-add-assertion.html View 1 chunk +16 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLSelectElement.cpp View 1 chunk +6 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
tkent
kochi@, would you review this please?
4 years, 4 months ago (2016-08-03 05:04:35 UTC) #7
kochi
lgtm
4 years, 4 months ago (2016-08-03 05:28:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2208483003/1
4 years, 4 months ago (2016-08-03 05:43:48 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-03 05:47:17 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/3d36d86ae85cb65f5b9e67a492cb5ee48e4ebd3b Cr-Commit-Position: refs/heads/master@{#409466}
4 years, 4 months ago (2016-08-03 05:48:34 UTC) #13
findit-for-me
4 years, 4 months ago (2016-08-03 06:39:47 UTC) #14
Message was sent while issue was closed.
FYI: Findit try jobs (rerunning failed compile or tests) identified this CL
at revision 409466 as the culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...

Powered by Google App Engine
This is Rietveld 408576698