chrome/test/data/extensions/api_test/messaging/externally_connectable/sites/popup_opener.html - Issue 2208483002: Fix extension bindings injection for iframes (reland)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/extensions/api_test/messaging/externally_connectable/sites/popup_opener.html

Issue 2208483002: Fix extension bindings injection for iframes (reland) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add fix and test for bug 630928, and logging to existing test Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/extensions/extension_messages_apitest.cc ('K') | « chrome/test/data/extensions/api_test/bindings/message_sender/public.html ('k') | extensions/renderer/script_context.cc » ('j') | extensions/renderer/script_context.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>

2 <!--	1 <!--

3 Copyright 2016 The Chromium Authors. All rights reserved.	2 Copyright 2016 The Chromium Authors. All rights reserved.

4 Use of this source code is governed by a BSD-style license that can be	3 Use of this source code is governed by a BSD-style license that can be

5 found in the LICENSE file.	4 found in the LICENSE file.

6 -->	5 -->

7 <html>	6 <script>

8 <head>	7 var url = location.href.replace("popup_opener.html", "chromium.org.html");
	Devlin 2016/08/03 16:16:49 nit: prefer single quotes. nit: prefer single quotes. asargent_no_longer_on_chrome 2016/08/04 05:47:18 Oops, sorry, old habits die hard. Fixed. Show quoted text On 2016/08/03 16:16:49, Devlin wrote: > nit: prefer single quotes. Oops, sorry, old habits die hard. Fixed.
9 </head>	8 window.open(url, "_blank");

10 <body>	9 </script>

11 <div id="container"></div>

12 <script src="window.js"></script>

13 </body>

14 </html>

OLD	NEW