Rework quick unlock settings to follow new specs.

Rework quick unlock settings to follow new specs.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/631c74536738819ce38adb964bb86a1361d753ae
Cr-Commit-Position: refs/heads/master@{#411142}

[jdufault, 2016-08-04 00:24:11]

Description was changed from

==========
Rework quick unlock settings to follow new specs.

BUG=
==========

to

==========
Rework quick unlock settings to follow new specs.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[jdufault, 2016-08-04 00:24:31]

The CQ bit was checked by jdufault@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-04 00:25:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-04 01:17:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-04 01:17:19]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jdufault, 2016-08-04 18:32:38]

The CQ bit was checked by jdufault@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-04 18:33:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jdufault, 2016-08-04 18:58:54]

Description was changed from

==========
Rework quick unlock settings to follow new specs.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Rework quick unlock settings to follow new specs.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[jdufault, 2016-08-04 18:58:54]

jdufault@chromium.org changed reviewers:
+ tommycli@chromium.org

[jdufault, 2016-08-04 18:59:03]

Patchset #1 (id:1) has been deleted

[jdufault, 2016-08-04 19:00:04]

Tommy, PTAL. Sorry about the big patch set size; I think most of it is from
moving files around.

[commit-bot: I haz the power, 2016-08-04 19:41:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-04 19:41:05]

Dry run: This issue passed the CQ dry run.

[tommycli, 2016-08-05 17:46:20]

overall seems to be a good improvement. i left comments below

https://codereview.chromium.org/2208473007/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/people_page/lock_screen.html (right):

https://codereview.chromium.org/2208473007/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/people_page/lock_screen.html:20:
text-transform: none;
What does this do?

https://codereview.chromium.org/2208473007/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/people_page/lock_screen.html:42: <div
class="settings-box single-column">
In the mocks, isn't this above the radio group?

https://codereview.chromium.org/2208473007/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/people_page/lock_screen.html:48:
<settings-password-prompt-dialog id="passwordPrompt"
Is it intended that the "Confirm your password" dialog opens AFTER navigating to
the "Configure screen lock" subpage?

https://codereview.chromium.org/2208473007/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/people_page/lock_screen.js (right):

https://codereview.chromium.org/2208473007/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/people_page/lock_screen.js:13: *  
set-modes="[[quickUnlockSetModes]]"
Is this example usage still up to date? It doesn't seem like set-modes attr is
used in people_page.

https://codereview.chromium.org/2208473007/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/people_page/lock_screen.js:18: (function() {
Since there's no variables here you want to keep out of the global scope, i
think this (function() { business is unnecessary. Also I don't think 'use
strict' does anything, but I might be wrong there.

https://codereview.chromium.org/2208473007/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/people_page/lock_screen.js:27: /** @type
{!settings.Route} */
Since this is new code, I recommend using the new pattern:
- Removing the currentRoute property
- No longer passing the attribute in via current-route="{{currentRoute}}" during
element creation.
- Instead add settings.RouteObserverBehavior. It should call the
currentRouteChanged method you can override.
- You can access the current route via "settings.getCurrentRoute()"

https://codereview.chromium.org/2208473007/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/people_page/lock_screen.js:42: setModes_: {
Since this setModes_ usage is subtle, it could use a comment. Maybe something
like:

setModes_ is a partially applied function that stores the previously entered
password. It's defined only when the user has already entered a valid password.

Maybe there's a shorter way of describing it.

https://codereview.chromium.org/2208473007/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/people_page/lock_screen.js:48: //
selectedUnlockType is defined in LockStateBehavior.
nit: Comment should probably be like: /** Foo */

https://codereview.chromium.org/2208473007/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/people_page/lock_screen.js:52:
onRouteChanged_: function(currentRoute) {
If you go with the settings.RouteObserverBehavior technique, It should be:

  /** @protected */
  currentRouteChanged: function() {

https://codereview.chromium.org/2208473007/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/people_page/lock_screen.js:98: * Retruns true
if the setup pin section should be shown.
typo: Returns

https://codereview.chromium.org/2208473007/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/people_page/lock_screen.js:100: * polymer know
about the dependency.
nit: indent four spaces, then Polymer

https://codereview.chromium.org/2208473007/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/people_page/lock_screen.js:103: showSetupPin_:
function(selectedUnlockType) {
nit: maybe rename: showConfigurePinButton_ ?

https://codereview.chromium.org/2208473007/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/people_page/lock_screen.js:108:
getSetupPinText_: function() {
My interpretation of the mocks was that selecting the "Pin or Password" option
would automatically open the pin setup dialog. If that's the case, there's no
need for this fn.

https://codereview.chromium.org/2208473007/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/people_page/lock_state_behavior.html
(right):

https://codereview.chromium.org/2208473007/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/people_page/lock_state_behavior.html:2:
<script src="/people_page/lock_state_behavior.js"></script>
Can this just be src="lock_state_behavior.js"?

https://codereview.chromium.org/2208473007/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/people_page/lock_state_behavior.js
(right):

https://codereview.chromium.org/2208473007/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/people_page/lock_state_behavior.js:37: hasPin:
{
Maybe this is no longer needed if selecting the last radio box automatically
opens the dialog?

https://codereview.chromium.org/2208473007/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/people_page/password_prompt_dialog.html
(right):

https://codereview.chromium.org/2208473007/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/people_page/password_prompt_dialog.html:40:
<div class="align-end settings-box continuation">
Does a plain div with the "button-strip" class work? Then we can remove two CSS
classes

https://codereview.chromium.org/2208473007/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/people_page/password_prompt_dialog.js
(right):

https://codereview.chromium.org/2208473007/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/people_page/password_prompt_dialog.js:8: *
'settings-password-prompt-dialog' shows a dialog which asks for the user to
Nice adaptation of existing code here!

https://codereview.chromium.org/2208473007/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/people_page/people_page.html (right):

https://codereview.chromium.org/2208473007/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/people_page/people_page.html:173: <div
class="settings-box two-line" on-tap="onLockTap_" actionable>
Maybe rename to onConfigureLockScreenTap_?

https://codereview.chromium.org/2208473007/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/people_page/setup_pin_dialog.html
(right):

https://codereview.chromium.org/2208473007/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/people_page/setup_pin_dialog.html:7:
<dom-module id="settings-setup-pin-dialog">
Is there any new stuff in here I should pay extra scrutiny here? I think I
reviewed most of this warning/error logic already.

Or is this a straight port of the old code into a dialog? Does using
--similarity on git cl upload yield a move-diff?

https://codereview.chromium.org/2208473007/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/people_page/setup_pin_dialog.html:20:
--iron-icon-fill-color: var(--paper-grey-500);
Can this be consolidated into .warning? I think I asked you this last time too.

https://codereview.chromium.org/2208473007/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/people_page/setup_pin_dialog.js (right):

https://codereview.chromium.org/2208473007/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/people_page/setup_pin_dialog.js:12: *  
set-modes="[[quickUnlockSetModes]]"
fold into above line and add ">" ending char

https://codereview.chromium.org/2208473007/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/people_page/setup_pin_dialog.js:89: //
TODO(jdufault): Make sure we reset flow if half-completed.
?

https://codereview.chromium.org/2208473007/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/people_page/setup_pin_dialog.js:247: if
(!isConfirmStep)
Ternary expression?

https://codereview.chromium.org/2208473007/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/people_page/setup_pin_dialog.js:258: if
(!isConfirmStep)
Ternary expression?

[jdufault, 2016-08-05 20:07:04]

The CQ bit was checked by jdufault@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-05 20:07:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jdufault, 2016-08-05 20:09:58]

Patchset #3 (id:60001) has been deleted

[jdufault, 2016-08-05 20:52:27]

The CQ bit was checked by jdufault@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-05 20:52:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jdufault, 2016-08-05 20:59:52]

https://codereview.chromium.org/2208473007/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/people_page/lock_screen.html (right):

https://codereview.chromium.org/2208473007/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/people_page/lock_screen.html:20:
text-transform: none;
On 2016/08/05 17:46:18, tommycli wrote:
> What does this do?

Removes the all-caps from the "action-link" paper-button below.

https://codereview.chromium.org/2208473007/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/people_page/lock_screen.html:42: <div
class="settings-box single-column">
On 2016/08/05 17:46:18, tommycli wrote:
> In the mocks, isn't this above the radio group?

That got changed around in the newest mocks
(https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Inner%20Pag...).

https://codereview.chromium.org/2208473007/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/people_page/lock_screen.html:48:
<settings-password-prompt-dialog id="passwordPrompt"
On 2016/08/05 17:46:18, tommycli wrote:
> Is it intended that the "Confirm your password" dialog opens AFTER navigating
to
> the "Configure screen lock" subpage?

I implemented it that way for simplicity, since if the user navigates directly
to this page they will have also have to enter their password. The alternative
is kicking them back to people, bringing up a password page, and then routing
back here.

https://codereview.chromium.org/2208473007/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/people_page/lock_screen.js (right):

https://codereview.chromium.org/2208473007/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/people_page/lock_screen.js:13: *  
set-modes="[[quickUnlockSetModes]]"
On 2016/08/05 17:46:19, tommycli wrote:
> Is this example usage still up to date? It doesn't seem like set-modes attr is
> used in people_page.

Done.

https://codereview.chromium.org/2208473007/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/people_page/lock_screen.js:18: (function() {
On 2016/08/05 17:46:19, tommycli wrote:
> Since there's no variables here you want to keep out of the global scope, i
> think this (function() { business is unnecessary. Also I don't think 'use
> strict' does anything, but I might be wrong there.

Done.

https://codereview.chromium.org/2208473007/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/people_page/lock_screen.js:27: /** @type
{!settings.Route} */
On 2016/08/05 17:46:19, tommycli wrote:
> Since this is new code, I recommend using the new pattern:
> - Removing the currentRoute property
> - No longer passing the attribute in via current-route="{{currentRoute}}"
during
> element creation.
> - Instead add settings.RouteObserverBehavior. It should call the
> currentRouteChanged method you can override.
> - You can access the current route via "settings.getCurrentRoute()"

Done.

https://codereview.chromium.org/2208473007/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/people_page/lock_screen.js:42: setModes_: {
On 2016/08/05 17:46:19, tommycli wrote:
> Since this setModes_ usage is subtle, it could use a comment. Maybe something
> like:
> 
> setModes_ is a partially applied function that stores the previously entered
> password. It's defined only when the user has already entered a valid
password.
> 
> Maybe there's a shorter way of describing it.

Done.

https://codereview.chromium.org/2208473007/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/people_page/lock_screen.js:48: //
selectedUnlockType is defined in LockStateBehavior.
On 2016/08/05 17:46:19, tommycli wrote:
> nit: Comment should probably be like: /** Foo */

Done.

https://codereview.chromium.org/2208473007/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/people_page/lock_screen.js:52:
onRouteChanged_: function(currentRoute) {
On 2016/08/05 17:46:19, tommycli wrote:
> If you go with the settings.RouteObserverBehavior technique, It should be:
> 
>   /** @protected */
>   currentRouteChanged: function() {

Done.

https://codereview.chromium.org/2208473007/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/people_page/lock_screen.js:98: * Retruns true
if the setup pin section should be shown.
On 2016/08/05 17:46:19, tommycli wrote:
> typo: Returns

Done.

https://codereview.chromium.org/2208473007/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/people_page/lock_screen.js:100: * polymer know
about the dependency.
On 2016/08/05 17:46:19, tommycli wrote:
> nit: indent four spaces, then Polymer

Done.

https://codereview.chromium.org/2208473007/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/people_page/lock_screen.js:103: showSetupPin_:
function(selectedUnlockType) {
On 2016/08/05 17:46:18, tommycli wrote:
> nit: maybe rename: showConfigurePinButton_ ?

Done.

https://codereview.chromium.org/2208473007/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/people_page/lock_screen.js:108:
getSetupPinText_: function() {
On 2016/08/05 17:46:19, tommycli wrote:
> My interpretation of the mocks was that selecting the "Pin or Password" option
> would automatically open the pin setup dialog. If that's the case, there's no
> need for this fn.

That part of the mocks is likely to change (UI review didn't like it).

https://codereview.chromium.org/2208473007/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/people_page/lock_state_behavior.html
(right):

https://codereview.chromium.org/2208473007/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/people_page/lock_state_behavior.html:2:
<script src="/people_page/lock_state_behavior.js"></script>
On 2016/08/05 17:46:19, tommycli wrote:
> Can this just be src="lock_state_behavior.js"?

Done.

https://codereview.chromium.org/2208473007/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/people_page/lock_state_behavior.js
(right):

https://codereview.chromium.org/2208473007/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/people_page/lock_state_behavior.js:37: hasPin:
{
On 2016/08/05 17:46:19, tommycli wrote:
> Maybe this is no longer needed if selecting the last radio box automatically
> opens the dialog?

Right! But unfortunately that's not the desired behavior :(

https://codereview.chromium.org/2208473007/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/people_page/password_prompt_dialog.html
(right):

https://codereview.chromium.org/2208473007/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/people_page/password_prompt_dialog.html:40:
<div class="align-end settings-box continuation">
On 2016/08/05 17:46:19, tommycli wrote:
> Does a plain div with the "button-strip" class work? Then we can remove two
CSS
> classes

Done, but the settings-box css is still needed to align the div on line 28 (the
label above the input box).

https://codereview.chromium.org/2208473007/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/people_page/password_prompt_dialog.js
(right):

https://codereview.chromium.org/2208473007/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/people_page/password_prompt_dialog.js:8: *
'settings-password-prompt-dialog' shows a dialog which asks for the user to
On 2016/08/05 17:46:19, tommycli wrote:
> Nice adaptation of existing code here!

:)

https://codereview.chromium.org/2208473007/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/people_page/people_page.html (right):

https://codereview.chromium.org/2208473007/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/people_page/people_page.html:173: <div
class="settings-box two-line" on-tap="onLockTap_" actionable>
On 2016/08/05 17:46:19, tommycli wrote:
> Maybe rename to onConfigureLockScreenTap_?

Done.

https://codereview.chromium.org/2208473007/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/people_page/setup_pin_dialog.html
(right):

https://codereview.chromium.org/2208473007/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/people_page/setup_pin_dialog.html:7:
<dom-module id="settings-setup-pin-dialog">
On 2016/08/05 17:46:19, tommycli wrote:
> Is there any new stuff in here I should pay extra scrutiny here? I think I
> reviewed most of this warning/error logic already.
> 
> Or is this a straight port of the old code into a dialog? Does using
> --similarity on git cl upload yield a move-diff?

Yea, not too many changes in this file.

https://codereview.chromium.org/2208473007/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/people_page/setup_pin_dialog.html:20:
--iron-icon-fill-color: var(--paper-grey-500);
On 2016/08/05 17:46:19, tommycli wrote:
> Can this be consolidated into .warning? I think I asked you this last time
too.

Iirc I investigated last time and the answer was no :(

https://codereview.chromium.org/2208473007/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/people_page/setup_pin_dialog.js (right):

https://codereview.chromium.org/2208473007/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/people_page/setup_pin_dialog.js:12: *  
set-modes="[[quickUnlockSetModes]]"
On 2016/08/05 17:46:20, tommycli wrote:
> fold into above line and add ">" ending char

Done.

https://codereview.chromium.org/2208473007/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/people_page/setup_pin_dialog.js:89: //
TODO(jdufault): Make sure we reset flow if half-completed.
On 2016/08/05 17:46:20, tommycli wrote:
> ?

Fixed the bug and removed the TODO.

https://codereview.chromium.org/2208473007/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/people_page/setup_pin_dialog.js:247: if
(!isConfirmStep)
On 2016/08/05 17:46:20, tommycli wrote:
> Ternary expression?

Done.

https://codereview.chromium.org/2208473007/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/people_page/setup_pin_dialog.js:258: if
(!isConfirmStep)
On 2016/08/05 17:46:20, tommycli wrote:
> Ternary expression?

Done.

[commit-bot: I haz the power, 2016-08-05 22:59:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-05 22:59:19]

Dry run: This issue passed the CQ dry run.

[tommycli, 2016-08-09 16:15:36]

lgtm sans nit below

https://codereview.chromium.org/2208473007/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/people_page/lock_screen.html (right):

https://codereview.chromium.org/2208473007/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/people_page/lock_screen.html:48:
<settings-password-prompt-dialog id="passwordPrompt"
On 2016/08/05 20:59:51, jdufault wrote:
> On 2016/08/05 17:46:18, tommycli wrote:
> > Is it intended that the "Confirm your password" dialog opens AFTER
navigating
> to
> > the "Configure screen lock" subpage?
> 
> I implemented it that way for simplicity, since if the user navigates directly
> to this page they will have also have to enter their password. The alternative
> is kicking them back to people, bringing up a password page, and then routing
> back here.

Acknowledged. I'm always pro-simplicity.

https://codereview.chromium.org/2208473007/diff/80001/chrome/browser/resource...
File chrome/browser/resources/settings/people_page/lock_screen.js (right):

https://codereview.chromium.org/2208473007/diff/80001/chrome/browser/resource...
chrome/browser/resources/settings/people_page/lock_screen.js:87:
!this.setModes_) {
nit: odd indent?

[jdufault, 2016-08-09 23:58:18]

https://codereview.chromium.org/2208473007/diff/80001/chrome/browser/resource...
File chrome/browser/resources/settings/people_page/lock_screen.js (right):

https://codereview.chromium.org/2208473007/diff/80001/chrome/browser/resource...
chrome/browser/resources/settings/people_page/lock_screen.js:87:
!this.setModes_) {
On 2016/08/09 16:15:36, tommycli wrote:
> nit: odd indent?

Done.

[jdufault, 2016-08-09 23:58:23]

The CQ bit was checked by jdufault@chromium.org

[jdufault, 2016-08-09 23:58:24]

The patchset sent to the CQ was uploaded after l-g-t-m from
tommycli@chromium.org
Link to the patchset: https://codereview.chromium.org/2208473007/#ps100001
(title: "Nit")

[commit-bot: I haz the power, 2016-08-09 23:59:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 00:03:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 00:03:39]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[jdufault, 2016-08-10 00:48:08]

The CQ bit was checked by jdufault@chromium.org

[jdufault, 2016-08-10 00:48:09]

The patchset sent to the CQ was uploaded after l-g-t-m from
tommycli@chromium.org
Link to the patchset: https://codereview.chromium.org/2208473007/#ps120001
(title: "Rebase")

[commit-bot: I haz the power, 2016-08-10 00:48:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 00:52:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 00:52:46]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[jdufault, 2016-08-10 17:50:06]

The CQ bit was checked by jdufault@chromium.org

[jdufault, 2016-08-10 17:50:06]

The patchset sent to the CQ was uploaded after l-g-t-m from
tommycli@chromium.org
Link to the patchset: https://codereview.chromium.org/2208473007/#ps140001
(title: "Rebase")

[commit-bot: I haz the power, 2016-08-10 17:51:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 18:01:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 18:01:04]

Try jobs failed on following builders:
  closure_compilation on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compila...)

[jdufault, 2016-08-10 18:15:21]

The CQ bit was checked by jdufault@chromium.org

[jdufault, 2016-08-10 18:15:22]

The patchset sent to the CQ was uploaded after l-g-t-m from
tommycli@chromium.org
Link to the patchset: https://codereview.chromium.org/2208473007/#ps160001
(title: "Fix closure (bad merge)")

[commit-bot: I haz the power, 2016-08-10 18:16:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 19:29:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 19:29:12]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[jdufault, 2016-08-10 20:03:58]

The CQ bit was checked by jdufault@chromium.org

[commit-bot: I haz the power, 2016-08-10 20:04:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 21:03:59]

Description was changed from

==========
Rework quick unlock settings to follow new specs.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Rework quick unlock settings to follow new specs.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-08-10 21:04:00]

Committed patchset #7 (id:160001)

[commit-bot: I haz the power, 2016-08-10 21:05:31]

Description was changed from

==========
Rework quick unlock settings to follow new specs.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Rework quick unlock settings to follow new specs.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/631c74536738819ce38adb964bb86a1361d753ae
Cr-Commit-Position: refs/heads/master@{#411142}
==========

[commit-bot: I haz the power, 2016-08-10 21:05:33]

Patchset 7 (id:??) landed as
https://crrev.com/631c74536738819ce38adb964bb86a1361d753ae
Cr-Commit-Position: refs/heads/master@{#411142}